Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756240AbbFPHey (ORCPT ); Tue, 16 Jun 2015 03:34:54 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:47988 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756118AbbFPHeo (ORCPT ); Tue, 16 Jun 2015 03:34:44 -0400 Message-ID: <1434440080.2069.49.camel@x220> Subject: Re: [PATCH linux-next 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit From: Paul Bolle To: Cyrille Pitchen Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Date: Tue, 16 Jun 2015 09:34:40 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 29 Just a nit: a license mismatch. On Mon, 2015-06-15 at 18:38 +0200, Cyrille Pitchen wrote: > --- /dev/null > +++ b/drivers/mfd/atmel-flexcom.c > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. This states the license is GPL v2 (or later) > +MODULE_LICENSE("GPL v2"); According to include/linux/module.h this states the license is (just) GPL v2. So I think that either the comment at the top of this file or the ident used in the MODULE_LICENSE() macro needs to change. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/