Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756476AbbFPIXs (ORCPT ); Tue, 16 Jun 2015 04:23:48 -0400 Received: from www.linutronix.de ([62.245.132.108]:43011 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754354AbbFPIXo (ORCPT ); Tue, 16 Jun 2015 04:23:44 -0400 Date: Tue, 16 Jun 2015 10:23:44 +0200 (CEST) From: Thomas Gleixner To: Vikas Shivappa cc: Peter Zijlstra , Vikas Shivappa , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, Matt Fleming , "Juvva, Kanaka D" , "Williamson, Glenn P" , "Auld, Will" Subject: Re: [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration In-Reply-To: Message-ID: References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-11-git-send-email-vikas.shivappa@linux.intel.com> <20150615140503.GD3644@twins.programming.kicks-ass.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 39 On Mon, 15 Jun 2015, Vikas Shivappa wrote: > On Mon, 15 Jun 2015, Peter Zijlstra wrote: > > > On Fri, Jun 12, 2015 at 11:17:17AM -0700, Vikas Shivappa wrote: > > > + /* > > > + * Probe test for Haswell CPUs. > > > + */ > > > + if (c->x86 == 0x6 && c->x86_model == 0x3f) > > > + return hsw_probetest(); > > > > Firstly, isn't a probe already a test? > > Will fix the name to hsw_probe > > > > > Secondly, there's more HSW models: > > > > case 60: /* 22nm Haswell Core */ > > case 63: /* 22nm Haswell Server */ > > case 69: /* 22nm Haswell ULT */ > > case 70: /* 22nm Haswell + GT3e (Intel Iris Pro graphics) */ > > > > Is this really only HSW server, > > Yes , this probe is only targeted at HSW servers as of now. > > or should they all be listed? you should know, whether they support that feature and need that quirk, Thanks tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/