Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756511AbbFPIZP (ORCPT ); Tue, 16 Jun 2015 04:25:15 -0400 Received: from mga14.intel.com ([192.55.52.115]:33038 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbbFPIZL (ORCPT ); Tue, 16 Jun 2015 04:25:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,625,1427785200"; d="scan'208";a="588656201" Message-ID: <557FDD62.2050209@linux.intel.com> Date: Tue, 16 Jun 2015 16:25:06 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thomas Gleixner CC: bhelgaas@google.com, benh@kernel.crashing.org, mingo@kernel.org, rdunlap@infradead.org, yinghai@kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, ying.huang@intel.com, konrad.wilk@oracle.com, hpa@zytor.com, bp@alien8.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/apic] genirq: Prevent crash in irq_move_irq() References: <1433145945-789-3-git-send-email-jiang.liu@linux.intel.com> <557FD4A6.7040301@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 41 On 2015/6/16 16:12, Thomas Gleixner wrote: > > > On Tue, 16 Jun 2015, Jiang Liu wrote: > >> On 2015/6/16 15:31, tip-bot for Jiang Liu wrote: >>> Commit-ID: 458526ec81d755dfaa17f3d863302afe6fbefca0 >>> Gitweb: http://git.kernel.org/tip/458526ec81d755dfaa17f3d863302afe6fbefca0 >>> Author: Jiang Liu >>> AuthorDate: Mon, 1 Jun 2015 16:05:11 +0800 >>> Committer: Thomas Gleixner >>> CommitDate: Tue, 16 Jun 2015 09:23:28 +0200 >>> >>> genirq: Prevent crash in irq_move_irq() >>> >>> The functions irq_move_irq() and irq_move_masked_irq() expect that the >>> caller passes the top-level irq_data to them when hierarchical >>> irqdomains are enabled. But that's not true when called from >>> apic_ack_edge(), which results in a null pointer dereference by >>> idata->chip->irq_mask(idata). >>> >>> Instead of fixing callers to passing top-level irq_data, we rather >>> change irq_move_irq()/irq_move_masked_irq() to accept any irq_data. >>> >>> Fixes: 52f518a3a7c 'x86/MSI: Use hierarchical irqdomains to manage MSI interrupts' >> Hi Thomas, >> This patch has dependency on patch "[Patch v3 01/36] genirq: >> Enhance irq_data_to_desc() to support hierarchy irqdomain" in the >> same patch set, otherwise irq_data_to_desc(idata) may return invalid >> irq_desc and may cause memory crash. > > That's why you should not mix bug fixes with performance improvement series. Yes, it's a lesson. I always fall into troubles when managing several inter-dependent patch sets at the same time. Thanks! Gerry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/