MIME-Version: 1.0
In-Reply-To: <557EC8F1.9010305@fau.de>
References: <557EC8F1.9010305@fau.de>
Date: Tue, 16 Jun 2015 10:47:32 +0200
Message-ID: <CALszF6C4JnCaaj-nG5oT3QCHhEK0upQDpzSngNLNvjM_6CJW0A@mail.gmail.com>
Subject: Re: serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE
From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Andreas Ruprecht <andreas.ruprecht@fau.de>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
        Peter Hurley <peter@hurleysoftware.com>,
        Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Stefan Hengelein <stefan.hengelein@fau.de>,
        Valentin Rothberg <valentinrothberg@gmail.com>,
        Paul Bolle <pebolle@tiscali.nl>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1225
Lines: 38

Hi Andreas,

2015-06-15 14:45 GMT+02:00 Andreas Ruprecht <andreas.ruprecht@fau.de>:
> Hi Maxime,
>
> your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
> was merged into linux-next today (i.e., next-20150615), and contains the
> following piece of code:
>
> [...]
> #if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) &&
> defined(CONFIG_MAGIC_SYSRQ)
> #define SUPPORT_SYSRQ
> #endif
> [...]
>
> The #if block can never be enabled as no symbol named
> SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean
> SERIAL_STM32_CONSOLE which you introduce in the same commit?

Yes, you a right, I meant SERIAL_STM32_CONSOLE.
I will prepare a fix.

>
> I detected the issue by running undertaker-checkpatch from the
> Undertaker tool suite (https://undertaker.cs.fau.de). There is also a
> tool in the Linux tree itself that can detect such issues
> (scripts/checkkconfigsymbols.py).

Ok thanks for the pointer! I didn't know these tools.

Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/