Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933106AbbFPIz1 (ORCPT ); Tue, 16 Jun 2015 04:55:27 -0400 Received: from mail-db3on0118.outbound.protection.outlook.com ([157.55.234.118]:27829 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756766AbbFPIzR convert rfc822-to-8bit (ORCPT ); Tue, 16 Jun 2015 04:55:17 -0400 From: "Abdul, Hussain (H.)" To: Sudip Mukherjee CC: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "Dighe, Niranjan (N.)" , "chris.park@atmel.com" , "Ravindran, Madhusudhanan (M.)" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "johnny.kim@atmel.com" , "rachel.kim@atmel.com" , "dean.lee@atmel.com" Subject: Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Thread-Topic: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Thread-Index: AQHQqAbF0CwDrTHHvkm8S3k9MdYSuQ== Date: Tue, 16 Jun 2015 08:55:13 +0000 Message-ID: References: <1434439941-6369-1-git-send-email-habdul@visteon.com> <20150616080955.GA1007@sudip-PC> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none; x-originating-ip: [74.112.164.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1112;3:lMJu9IGcROHluJUGiD3erhkGF7vI9+CAJPF0X3Zs3Mgc2ab7vU7xfG7ur7o8v5h7JDr9GQ07jDNWfHEhsXnJd/UDiptGhLOnAV7dRto39d6ih5rXakBuGnie5v1k4z0qPSGpLCEj78YTnv5okORwVw==;10:gDL5153MTLO9XqHHS1/zPEWAMOGQEcRvNro9WcQZ1oVAM5qkXizCL5g3STEli/praY2HnBV7REP3xEsDg6s4U/tn6iKM9MiXmewi9kYGvLQ=;6:DY/XMHDzItwZDAVM8aIZui14nPHpaEv5ree2f1Jw2jbhVwbBhkYXVBJMwy3OYEHh x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1112; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:DB5PR06MB1112;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1112; x-forefront-prvs: 06098A2863 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(57704003)(164054003)(51704005)(24454002)(377454003)(102836002)(5003600100002)(74316001)(46102003)(2900100001)(92566002)(77096005)(76576001)(87936001)(66066001)(2656002)(106116001)(40100003)(50986999)(76176999)(77156002)(122556002)(54356999)(5002640100001)(19580395003)(19580405001)(5001960100002)(110136002)(189998001)(33656002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1112;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2015 08:55:13.4711 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1112 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 35 On Tuesday 16 June 2015 01:40 PM, Sudip Mukherjee wrote: > On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote: >> From: Abdul Hussain >> >> This patch removes unwanted true and false from boolean tests. >> >> Signed-off-by: Abdul Hussain >> --- > >> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c >> index 17ab5cd..be1f6bf 100644 >> --- a/drivers/staging/wilc1000/host_interface.c >> +++ b/drivers/staging/wilc1000/host_interface.c >> @@ -7816,7 +7816,7 @@ static void *host_int_ParseJoinBssParam(tstrNetworkInfo *ptstrNetworkInfo) >> pNewJoinBssParam->rsn_cap[1] = pu8IEs[rsnIndex + 1]; >> rsnIndex += 2; >> } >> - pNewJoinBssParam->rsn_found = 1; >> + pNewJoinBssParam->rsn_found = true; > But this is not a boolean test, this is an assignement. > > regards > sudip > Sudip, Yes that is an assignment to the boolean variable. Do i need to modify the commit message or to send separate patch? Thanks, Abdul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/