Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933712AbbFPJTR (ORCPT ); Tue, 16 Jun 2015 05:19:17 -0400 Received: from casper.infradead.org ([85.118.1.10]:47603 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933117AbbFPJTI (ORCPT ); Tue, 16 Jun 2015 05:19:08 -0400 Date: Tue, 16 Jun 2015 11:18:57 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: Vikas Shivappa , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, Matt Fleming , "Juvva, Kanaka D" , "Williamson, Glenn P" , "Auld, Will" Subject: Re: [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration Message-ID: <20150616091857.GK3644@twins.programming.kicks-ass.net> References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-11-git-send-email-vikas.shivappa@linux.intel.com> <20150615140503.GD3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 25 On Mon, Jun 15, 2015 at 02:44:32PM -0700, Vikas Shivappa wrote: > >Secondly, there's more HSW models: > > > > case 60: /* 22nm Haswell Core */ > > case 63: /* 22nm Haswell Server */ > > case 69: /* 22nm Haswell ULT */ > > case 70: /* 22nm Haswell + GT3e (Intel Iris Pro graphics) */ > > > >Is this really only HSW server, > > Yes , this probe is only targeted at HSW servers as of now. But do the others have it? What you're targeting this code for is irrelevant, if those models have the hardware we should support them. > or should they all be listed? If they support it, yes. In any case, be explicit on which models have the hardware. IIRC your current Changelog has the words 'certain SKUs' in, which is as ambiguous as one can get. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/