Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933952AbbFPJ2L (ORCPT ); Tue, 16 Jun 2015 05:28:11 -0400 Received: from mail2.unitn.it ([193.205.194.22]:49485 "EHLO mail2.unitn.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932758AbbFPJ2C (ORCPT ); Tue, 16 Jun 2015 05:28:02 -0400 Message-ID: <557FEC1C.6050508@unitn.it> Date: Tue, 16 Jun 2015 11:27:56 +0200 From: Luca Abeni User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Zhiqiang Zhang , linux-kernel@vger.kernel.org, peterz@infradead.org, juri.lelli@gmail.com Subject: Re: [PATCH] sched/deadline: remove needless parameter in dl_runtime_exceeded() References: <1434338120-43773-1-git-send-email-zhangzhiqiang.zhang@huawei.com> In-Reply-To: <1434338120-43773-1-git-send-email-zhangzhiqiang.zhang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 49 Hello, On 06/15/2015 05:15 AM, Zhiqiang Zhang wrote: > Sine commit 269ad80(sched/deadline: Avoid double-accounting in > case of missed deadlines), parameter rq is no longer used, so > remove it. I do not know if other people have plans to use this "rq" parameter, but the patch looks ok to me. Thanks, Luca > > Signed-off-by: Zhiqiang Zhang > --- > kernel/sched/deadline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 5e95145..437ecdc 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -640,7 +640,7 @@ void init_dl_task_timer(struct sched_dl_entity *dl_se) > } > > static > -int dl_runtime_exceeded(struct rq *rq, struct sched_dl_entity *dl_se) > +int dl_runtime_exceeded(struct sched_dl_entity *dl_se) > { > return (dl_se->runtime <= 0); > } > @@ -684,7 +684,7 @@ static void update_curr_dl(struct rq *rq) > sched_rt_avg_update(rq, delta_exec); > > dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec; > - if (dl_runtime_exceeded(rq, dl_se)) { > + if (dl_runtime_exceeded(dl_se)) { > dl_se->dl_throttled = 1; > __dequeue_task_dl(rq, curr, 0); > if (unlikely(!start_dl_timer(dl_se, curr->dl.dl_boosted))) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/