Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757520AbbFPJls (ORCPT ); Tue, 16 Jun 2015 05:41:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47555 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757292AbbFPJlm (ORCPT ); Tue, 16 Jun 2015 05:41:42 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <557ECBC5.7000705@tycho.nsa.gov> References: <557ECBC5.7000705@tycho.nsa.gov> <16216.1417109138@warthog.procyon.org.uk> <545A51CB.6070107@tycho.nsa.gov> <20141105154217.2555.578.stgit@warthog.procyon.org.uk> <20141105154307.2555.9847.stgit@warthog.procyon.org.uk> <8813.1434123054@warthog.procyon.org.uk> To: Stephen Smalley Cc: dhowells@redhat.com, linux-unionfs@vger.kernel.org, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, drquigl , Eric Paris Subject: Re: [PATCH 5/7] SELinux: Handle opening of a unioned file MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32051.1434447696.1@warthog.procyon.org.uk> Date: Tue, 16 Jun 2015 10:41:36 +0100 Message-ID: <32052.1434447696@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 23 Stephen Smalley wrote: > It looks like commit 415103f9932d45f7927f4b17e3a9a13834cdb9a1 changed > selinux_inode_init_security()'s handling of SECURITY_FS_USE_MNTPOINT, > and this change was never propagated to selinux_dentry_init_security(). > However, that commit also did not update > security/selinux/hooks.c:may_create()'s logic for computing the new file > label when checking CREATE permission, and therefore introduced a > potential inconsistency between the label used for the permission check > and the label assigned to the inode. > > That's why I suggested that we need a common helper for all three to > ensure consistency there. Ah, okay. I didn't realise selinux_dentry_init_security() wasn't supposed to be so different. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/