Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932548AbbFPKPT (ORCPT ); Tue, 16 Jun 2015 06:15:19 -0400 Received: from sabertooth01.qualcomm.com ([65.197.215.72]:43593 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756410AbbFPKPO (ORCPT ); Tue, 16 Jun 2015 06:15:14 -0400 X-IronPort-AV: E=McAfee;i="5700,7163,7833"; a="90972200" X-IronPort-AV: E=Sophos;i="5.13,625,1427785200"; d="scan'208";a="911262897" From: Kalle Valo To: Nicholas Mc Guire CC: , , , Subject: Re: [PATCH] ath10k: mac: remove unreachable negative return check References: <1434039461-24899-1-git-send-email-hofrat@osadl.org> Date: Tue, 16 Jun 2015 13:14:46 +0300 In-Reply-To: <1434039461-24899-1-git-send-email-hofrat@osadl.org> (Nicholas Mc Guire's message of "Thu, 11 Jun 2015 18:17:41 +0200") Message-ID: <87a8w07yeh.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01C.na.qualcomm.com (10.85.0.83) To NASANEXM01G.na.qualcomm.com (10.85.0.33) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 19 Nicholas Mc Guire writes: > wait_event_timeout(), introduced in 'commit 5e3dd157d7e7 ("ath10k: mac80211 > driver for Qualcomm Atheros 802.11ac CQA98xx devices")' never returns < 0 > so the only failure condition to be checked is ==0 (timeout). Further the > return type is long not int - an appropriately named variable is added > and the assignments fixed up. > > Signed-off-by: Nicholas Mc Guire Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/