Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214AbbFPLLf (ORCPT ); Tue, 16 Jun 2015 07:11:35 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35472 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbbFPLLZ (ORCPT ); Tue, 16 Jun 2015 07:11:25 -0400 Date: Tue, 16 Jun 2015 16:41:11 +0530 From: Sudip Mukherjee To: "Abdul, Hussain (H.)" Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "Dighe, Niranjan (N.)" , "chris.park@atmel.com" , "Ravindran, Madhusudhanan (M.)" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "johnny.kim@atmel.com" , "rachel.kim@atmel.com" , "dean.lee@atmel.com" Subject: Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Message-ID: <20150616111111.GA15479@sudip-PC> References: <1434439941-6369-1-git-send-email-habdul@visteon.com> <20150616080955.GA1007@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 23 On Tue, Jun 16, 2015 at 08:55:13AM +0000, Abdul, Hussain (H.) wrote: > On Tuesday 16 June 2015 01:40 PM, Sudip Mukherjee wrote: > > On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote: > >> From: Abdul Hussain > > > > regards > > sudip > > > Sudip, > > Yes that is an assignment to the boolean variable. Do i need to modify the commit message or to send separate patch? if that assignment is related to the change in boolean test then it should be in the same patch. But in any case commit message should mention that change and the reason. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/