Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756622AbbFPL7D (ORCPT ); Tue, 16 Jun 2015 07:59:03 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60310 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754424AbbFPL6x (ORCPT ); Tue, 16 Jun 2015 07:58:53 -0400 Date: Tue, 16 Jun 2015 12:58:42 +0100 From: Mark Brown To: Maxime Coquelin Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Message-ID: <20150616115842.GP18309@sirena.org.uk> References: <1434455599-18505-1-git-send-email-maxime.coquelin@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ScBGguMCFzdFq7Io" Content-Disposition: inline In-Reply-To: <1434455599-18505-1-git-send-email-maxime.coquelin@st.com> X-Cookie: do { User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.197.121.24 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regmap: Fix possible shift overflow in regmap_field_init() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 34 --ScBGguMCFzdFq7Io Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 16, 2015 at 01:53:19PM +0200, Maxime Coquelin wrote: > The way the mask is generated in regmap_field_init() is wrong. > Indeed, a field initialized with msb = 31 and lsb = 0 provokes a shift > overflow while calculating the mask field. Applied, thanks. --ScBGguMCFzdFq7Io Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVgA9xAAoJECTWi3JdVIfQQIwH/jpDEc3aLp9LjXd9A0cHW4SC 0gqs5Ew3TUHImv364rOszUnSth3Cy7k8wht0z62OGOWFITBnvfwWSOeUXo3g6sN5 Ta4sH1ldkWgG9d4pGOXaFqXhYTFc5Y/ZFf95+IlyZrUUXBCVZhJYzpfiKi0CE7Oh CVXXfgGzxNzLmX1PPSoKaQnzzTWqSPDkiAZMlZ9vctwYYLWcYtXo8GTAh3zM4IKF AYmfGBMPsM1TGW0qGxlTrf4HpYNHFlkcZttvKHWAZvcmXrQPlCp1RIjRAsgQsEdj 4I8R5W7tvt1tthby6/G42WDFFKXX4HO1WSzw1FM7G7HaH95u7FIZzf8IUv0J1rc= =rzye -----END PGP SIGNATURE----- --ScBGguMCFzdFq7Io-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/