Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756121AbbFPMUj (ORCPT ); Tue, 16 Jun 2015 08:20:39 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:34414 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbbFPMUg (ORCPT ); Tue, 16 Jun 2015 08:20:36 -0400 MIME-Version: 1.0 In-Reply-To: References: <1434367253-26577-1-git-send-email-chaotian.jing@mediatek.com> <1434367253-26577-5-git-send-email-chaotian.jing@mediatek.com> From: Daniel Kurtz Date: Tue, 16 Jun 2015 20:20:14 +0800 X-Google-Sender-Auth: Ik4eWZjY-06ZOucrV14hgp31h5s Message-ID: Subject: Re: [PATCH v6 4/7] arm64: dts: mediatek: Add MT8173 MMC dts To: Chaotian Jing Cc: Rob Herring , Matthias Brugger , Chris Ball , Ulf Hansson , Mark Rutland , James Liao , Russell King - ARM Linux , srv_heupstream , Arnd Bergmann , "open list:OPEN FIRMWARE AND..." , Hongzhou Yang , Catalin Marinas , bin.zhang@mediatek.com, linux-mmc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Will Deacon , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, Sascha Hauer , "Joe.C" , Eddie Huang , "linux-arm-kernel@lists.infradead.org" , Henry Chen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 10027 Lines: 242 On Tue, Jun 16, 2015 at 7:39 PM, Daniel Kurtz wrote: > Hi Chaotian, > > On Mon, Jun 15, 2015 at 7:20 PM, Chaotian Jing > wrote: >> From: Eddie Huang >> >> Add node mmc0 ~ mmc3 for mt8173.dtsi >> Add node mmc0, mmc1 for mt8173-evb.dts >> >> Signed-off-by: Chaotian Jing >> Signed-off-by: Eddie Huang >> --- >> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 126 ++++++++++++++++++++++++++++ >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 45 +++++++++- >> 2 files changed, 170 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts >> index b1560c9..762ec61 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts >> @@ -33,6 +33,132 @@ >> chosen { }; >> }; >> >> +&mmc0 { >> + pinctrl-names = "default", "state_uhs"; >> + pinctrl-0 = <&mmc0_pins_default>; >> + pinctrl-1 = <&mmc0_pins_uhs>; >> + status = "okay"; >> + bus-width = <8>; >> + max-frequency = <50000000>; >> + cap-mmc-highspeed; >> + vmmc-supply = <&mt6397_vemc_3v3_reg>; >> + vqmmc-supply = <&mt6397_vio18_reg>; I also can't find phandles for these regulators. >> + non-removable; >> +}; >> + >> +&mmc1 { >> + pinctrl-names = "default", "state_uhs"; >> + pinctrl-0 = <&mmc1_pins_default>; >> + pinctrl-1 = <&mmc1_pins_uhs>; >> + status = "okay"; >> + bus-width = <4>; >> + max-frequency = <50000000>; >> + cap-sd-highspeed; >> + sd-uhs-sdr25; >> + cd-gpios = <&pio 132 0>; >> + vmmc-supply = <&mt6397_vmch_reg>; >> + vqmmc-supply = <&mt6397_vmc_reg>; nor these regulators. Which kernel branch are you basing your patch set on? Thanks, -Dan >> +}; >> + >> +&pio { >> + mmc0_pins_default: mmc0default { >> + pins_cmd_dat { >> + pinmux = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + input-enable; >> + bias-pull-up; >> + }; >> + >> + pins_clk { >> + pinmux = ; >> + bias-pull-down; >> + }; >> + >> + pins_rst { >> + pinmux = ; >> + bias-pull-up; >> + }; >> + }; >> + >> + mmc1_pins_default: mmc1default { >> + pins_cmd_dat { >> + pinmux = , >> + , >> + , >> + , >> + ; >> + input-enable; >> + drive-strength = ; >> + bias-pull-up = ; >> + }; >> + >> + pins_clk { >> + pinmux = ; >> + bias-pull-down; >> + drive-strength = ; >> + }; >> + >> + pins_insert { >> + pinmux = ; >> + bias-pull-up; >> + }; >> + }; >> + >> + mmc0_pins_uhs: mmc0@0{ >> + pins_cmd_dat { >> + pinmux = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + input-enable; >> + drive-strength = ; >> + bias-pull-up = ; >> + }; >> + >> + pins_clk { >> + pinmux = ; >> + drive-strength = ; >> + bias-pull-down = ; >> + }; >> + >> + pins_rst { >> + pinmux = ; >> + bias-pull-up; >> + }; >> + }; >> + >> + mmc1_pins_uhs: mmc1@0 { >> + pins_cmd_dat { >> + pinmux = , >> + , >> + , >> + , >> + ; >> + input-enable; >> + drive-strength = ; >> + bias-pull-up = ; >> + }; >> + >> + pins_clk { >> + pinmux = ; >> + drive-strength = ; >> + bias-pull-down = ; >> + }; >> + }; >> +}; >> + >> &pwrap { >> pmic: mt6397 { >> compatible = "mediatek,mt6397"; >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> index 512e4eb..56ea429 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> @@ -288,7 +288,50 @@ >> reg = <0 0x19000000 0 0x1000>; >> #clock-cells = <1>; >> }; >> - }; >> >> + mmc0: mmc@11230000 { >> + compatible = "mediatek,mt8173-mmc", >> + "mediatek,mt8135-mmc"; >> + reg = <0 0x11230000 0 0x1000>; >> + interrupts = ; >> + clocks = <&pericfg CLK_PERI_MSDC30_0>, >> + <&topckgen CLK_TOP_MSDC50_0_H_SEL>; >> + clock-names = "source", "hclk"; >> + status = "disabled"; >> + }; >> + >> + mmc1: mmc@11240000 { >> + compatible = "mediatek,mt8173-mmc", >> + "mediatek,mt8135-mmc"; >> + reg = <0 0x11240000 0 0x1000>; >> + interrupts = ; >> + clocks = <&pericfg CLK_PERI_MSDC30_1>, >> + <&clk_null>; > > This requires a "clk_null" phandle, but I have not seen a patch adding > that on the public list. > Did I miss a patch? > > -Dan > >> + clock-names = "source", "hclk"; >> + status = "disabled"; >> + }; >> + >> + mmc2: mmc@11250000 { >> + compatible = "mediatek,mt8173-mmc", >> + "mediatek,mt8135-mmc"; >> + reg = <0 0x11250000 0 0x1000>; >> + interrupts = ; >> + clocks = <&pericfg CLK_PERI_MSDC30_2>, >> + <&clk_null>; >> + clock-names = "source", "hclk"; >> + status = "disabled"; >> + }; >> + >> + mmc3: mmc@11260000 { >> + compatible = "mediatek,mt8173-mmc", >> + "mediatek,mt8135-mmc"; >> + reg = <0 0x11260000 0 0x1000>; >> + interrupts = ; >> + clocks = <&pericfg CLK_PERI_MSDC30_3>, >> + <&topckgen CLK_TOP_MSDC50_2_H_SEL>; >> + clock-names = "source", "hclk"; >> + status = "disabled"; >> + }; >> + }; >> }; >> >> -- >> 1.8.1.1.dirty >> >> >> _______________________________________________ >> Linux-mediatek mailing list >> Linux-mediatek@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-mediatek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/