Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753752AbbFPMYr (ORCPT ); Tue, 16 Jun 2015 08:24:47 -0400 Received: from mail-db3on0128.outbound.protection.outlook.com ([157.55.234.128]:42384 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751120AbbFPMYi convert rfc822-to-8bit (ORCPT ); Tue, 16 Jun 2015 08:24:38 -0400 From: "Abdul, Hussain (H.)" To: Sudip Mukherjee CC: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "Dighe, Niranjan (N.)" , "chris.park@atmel.com" , "Ravindran, Madhusudhanan (M.)" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "johnny.kim@atmel.com" , "rachel.kim@atmel.com" , "dean.lee@atmel.com" Subject: Re: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Thread-Topic: [PATCH] Staging: wilc1000: Boolean tests don't need comparisons Thread-Index: AQHQqAbF0CwDrTHHvkm8S3k9MdYSuQ== Date: Tue, 16 Jun 2015 12:24:35 +0000 Message-ID: References: <1434439941-6369-1-git-send-email-habdul@visteon.com> <20150616080955.GA1007@sudip-PC> <20150616111111.GA15479@sudip-PC> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none; x-originating-ip: [74.112.164.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1111;3:VcHKdKk0DAIEVvtBokMxGoiYeb9K85/0np7v4SupZNSyJfjR6zJl4FZoAdy1mWXFIC4D8pgd3CT86ZZ3ucnvEdZcTJ6wlaYeG0ffQsFQU9vuATKwsKUwsixpZhVYX3FuZiQa0HwHOf+jq/5QAgnReQ==;10:uVAh1eNUdPK4JOVLmekmlE3XX2BHt+c+coywjqehr5YeLvk20QYOwyZOGM18zFX/aREhQ1b6o664GYYAiN0LKXz+6gzMNIspOa1WpiGPyyg=;6:gclI+XmD7J792ZU4ygqs6q5hXphev7IPAsNRaT6HLHG7xUVbef4681RJuEXTQwDB x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1111; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:DB5PR06MB1111;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1111; x-forefront-prvs: 06098A2863 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(164054003)(377454003)(24454002)(51704005)(57704003)(5002640100001)(77156002)(106116001)(40100003)(76576001)(93886004)(33656002)(66066001)(110136002)(5001960100002)(189998001)(92566002)(62966003)(76176999)(50986999)(54356999)(74316001)(2656002)(87936001)(5003600100002)(122556002)(46102003)(102836002)(77096005)(19580405001)(86362001)(2900100001)(19580395003);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1111;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2015 12:24:35.2062 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1111 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 28 On Tuesday 16 June 2015 04:41 PM, Sudip Mukherjee wrote: > On Tue, Jun 16, 2015 at 08:55:13AM +0000, Abdul, Hussain (H.) wrote: >> On Tuesday 16 June 2015 01:40 PM, Sudip Mukherjee wrote: >>> On Tue, Jun 16, 2015 at 07:33:42AM +0000, Abdul, Hussain (H.) wrote: >>>> From: Abdul Hussain >>> regards >>> sudip >>> >> Sudip, >> >> Yes that is an assignment to the boolean variable. Do i need to modify the commit message or to send separate patch? > if that assignment is related to the change in boolean test then it should > be in the same patch. But in any case commit message should mention that > change and the reason. > > regards > sudip > > I have sent separate patch for this change. Thanks, Abdul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/