Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756715AbbFPOEl (ORCPT ); Tue, 16 Jun 2015 10:04:41 -0400 Received: from mail-db3on0128.outbound.protection.outlook.com ([157.55.234.128]:61696 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754366AbbFPOD7 convert rfc822-to-8bit (ORCPT ); Tue, 16 Jun 2015 10:03:59 -0400 From: "Abdul, Hussain (H.)" To: "gregkh@linuxfoundation.org" CC: "Ravindran, Madhusudhanan (M.)" , "Dighe, Niranjan (N.)" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 4/6] Staging: comedi: dac02: Simplify a trivial if-return sequence Thread-Topic: [PATCH 4/6] Staging: comedi: dac02: Simplify a trivial if-return sequence Thread-Index: AQHQqD1ItWdJ0BfaqUimHfKbId+afQ== Date: Tue, 16 Jun 2015 14:03:55 +0000 Message-ID: <1434463343-22343-4-git-send-email-habdul@visteon.com> References: <1434463343-22343-1-git-send-email-habdul@visteon.com> In-Reply-To: <1434463343-22343-1-git-send-email-habdul@visteon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [74.112.167.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1110;3:2QjhWzF6LyHdCwizXGNxGzDDQDAhQ4OlbfqgcUrgieyFNUDnxuWChhBv5erHHoFBKaLORudBpYY66e0LbLFVoPj3JWzD8aOx66YsaQsFjSAa5Bfl2Xw4jQOYWT2fmhsgAax5yJTXfIwhodnPCX4EDQ==;10:x5S8/VPvXn457oOqPL4R43HtRFseYTXhWbJzClqF5hDQVqf1ePyExlE4OPqJrjI9jooklUoyHGVinwQt3U/w4jBn3e+ysNn/CTiGwLd3oIE=;6:N/enbJDWEJwbEvDbp32HR2yBuv/qAMZH5jHU7M4OSherQRFUqroukndxElJ4neZf x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:DB5PR06MB1110;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1110; x-forefront-prvs: 06098A2863 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(102836002)(2900100001)(77096005)(2950100001)(5002640100001)(62966003)(50226001)(36756003)(106116001)(50986999)(40100003)(189998001)(76176999)(122556002)(66066001)(77156002)(5001960100002)(110136002)(92566002)(2351001)(87936001)(229853001)(33646002)(5890100001)(2501003)(2656002)(46102003)(86362001)(19580405001)(19580395003);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1110;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2015 14:03:55.9916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1110 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 34 From: Abdul Hussain This patch simplify a trivial if-return sequence. Possibly combine with a preceding function call. Signed-off-by: Abdul Hussain --- drivers/staging/comedi/drivers/dac02.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/dac02.c b/drivers/staging/comedi/drivers/dac02.c index a6798ad..a562df4 100644 --- a/drivers/staging/comedi/drivers/dac02.c +++ b/drivers/staging/comedi/drivers/dac02.c @@ -130,11 +130,7 @@ static int dac02_attach(struct comedi_device *dev, struct comedi_devconfig *it) s->range_table = &das02_ao_ranges; s->insn_write = dac02_ao_insn_write; - ret = comedi_alloc_subdev_readback(s); - if (ret) - return ret; - - return 0; + return comedi_alloc_subdev_readback(s); } static struct comedi_driver dac02_driver = { -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/