Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756931AbbFPPoa (ORCPT ); Tue, 16 Jun 2015 11:44:30 -0400 Received: from one.firstfloor.org ([193.170.194.197]:58559 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753221AbbFPPoY (ORCPT ); Tue, 16 Jun 2015 11:44:24 -0400 Date: Tue, 16 Jun 2015 17:44:22 +0200 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: David Ahern , "Liang, Kan" , Andi Kleen , "linux-kernel@vger.kernel.org" , "Huang, Ying" Subject: Re: [PATCH 1/1] perf,tools: add time out to force stop endless mmap processing Message-ID: <20150616154422.GA19417@two.firstfloor.org> References: <557A28F6.8040603@gmail.com> <37D7C6CF3E00A74B8858931C1DB2F077018767AD@SHSMSX103.ccr.corp.intel.com> <557AFDB1.7030902@gmail.com> <37D7C6CF3E00A74B8858931C1DB2F07701876834@SHSMSX103.ccr.corp.intel.com> <557B16C4.7000000@gmail.com> <37D7C6CF3E00A74B8858931C1DB2F07701876CB2@SHSMSX103.ccr.corp.intel.com> <557B3309.4080002@gmail.com> <37D7C6CF3E00A74B8858931C1DB2F07701876D60@SHSMSX103.ccr.corp.intel.com> <557BB084.8030800@gmail.com> <20150616151159.GF10374@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150616151159.GF10374@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 20 > Perhaps we should add a per-thread-proc-map-processing timeout parameter > to the synthesizing routines instead of having that hardcoded, i.e. > allow the tool to specify what is reasonable for it, but that wouldn't > be strictly required for a first patch, emitting the dialog box above > after synthesizing, if truncation happened, is. > > Agreed? If you make top emit a dialog box please make it appear only once and have a timeout so that it doesn't block it forever I personally would prefer of top just doing best effort and not giving such warnings which the user cannot do anything about anyways. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/