Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756991AbbFPPqc (ORCPT ); Tue, 16 Jun 2015 11:46:32 -0400 Received: from mail.skyhub.de ([78.46.96.112]:44955 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbbFPPqT (ORCPT ); Tue, 16 Jun 2015 11:46:19 -0400 Date: Tue, 16 Jun 2015 17:46:11 +0200 From: Borislav Petkov To: Andrey Ryabinin Cc: Alexander Popov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrey Konovalov , Andrew Morton , Andy Lutomirski , Alexander Kuleshov , Denys Vlasenko , Peter Zijlstra , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] x86_64: remove not needed clear_page for init_level4_page Message-ID: <20150616154611.GJ17786@pd.tnic> References: <1433842921-18055-1-git-send-email-alpopov@ptsecurity.com> <1433842921-18055-2-git-send-email-alpopov@ptsecurity.com> <20150616111632.GF17786@pd.tnic> <20150616113436.GG17786@pd.tnic> <55800C42.4050702@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55800C42.4050702@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 21 On Tue, Jun 16, 2015 at 02:45:06PM +0300, Andrey Ryabinin wrote: > Can't we just move clear_page(init_level4_pgt) higher? Before or right > after clear_bss() (iow before kasan_early_init()). That sounds much better. And I don't see anything depending on init_level4_pgt before we clear it. And it boots here if I move it before kasan_map_early_shadow(early_level4_pgt); -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/