Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756694AbbFPPwy (ORCPT ); Tue, 16 Jun 2015 11:52:54 -0400 Received: from smtprelay0148.hostedemail.com ([216.40.44.148]:41480 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756270AbbFPPwq (ORCPT ); Tue, 16 Jun 2015 11:52:46 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3350:3622:3865:3867:3868:3871:3872:3873:4385:5007:6261:7875:8660:10004:10400:10848:10967:11026:11232:11658:11914:12296:12517:12519:12740:13069:13148:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: jelly00_8c2383cb06216 X-Filterd-Recvd-Size: 1638 Date: Tue, 16 Jun 2015 11:52:40 -0400 From: Steven Rostedt To: Daniel Wagner Cc: paulmck@linux.vnet.ibm.com, Alexei Starovoitov , Daniel Wagner , LKML Subject: Re: call_rcu from trace_preempt Message-ID: <20150616115240.75f9187b@gandalf.local.home> In-Reply-To: <20150616114151.3681a9e8@gandalf.local.home> References: <557F509D.2000509@plumgrid.com> <20150615230702.GB3913@linux.vnet.ibm.com> <557F7764.5060707@plumgrid.com> <20150616021458.GE3913@linux.vnet.ibm.com> <557FB7E1.6080004@plumgrid.com> <20150616122733.GG3913@linux.vnet.ibm.com> <558018DD.1080701@monom.org> <20150616114151.3681a9e8@gandalf.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 22 On Tue, 16 Jun 2015 11:41:51 -0400 Steven Rostedt wrote: > > if (l) { > > hlist_del_rcu(&l->hash_node); > > htab->count--; > > - kfree_rcu(l, rcu); > > + /* kfree_rcu(l, rcu); */ > > So this kfree_rcu() is only being used to defer a free, and has nothing > to do with having to free 'l' from rcu? > If you still require kfree_rcu() but can not call it here, still use an irq_work, and have the irq_work handler call kfree_rcu(). -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/