Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756802AbbFPRjX (ORCPT ); Tue, 16 Jun 2015 13:39:23 -0400 Received: from foss.arm.com ([217.140.101.70]:37562 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbbFPRjO (ORCPT ); Tue, 16 Jun 2015 13:39:14 -0400 Date: Tue, 16 Jun 2015 18:39:07 +0100 From: Will Deacon To: David Long Cc: "H. Peter Anvin" , Andy Lutomirski , Anton Blanchard , Behan Webster , Benjamin Herrenschmidt , Eric Paris , Heiko Carstens , Ingo Molnar , Jan Willeke , Kees Cook , Martin Schwidefsky , Michael Ellerman , Nikolay Borisov , Oleg Nesterov , Paul Mackerras , Richard Kuo , Robert Richter , Roland McGrath , Russell King , Tejun Heo , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , "linux-hexagon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux390@de.ibm.com" , "linuxppc-dev@lists.ozlabs.org" , "x86@kernel.org" Subject: Re: [PATCH 0/2] Consolidate redundant register/stack access code Message-ID: <20150616173907.GV30522@arm.com> References: <1434386579-6045-1-git-send-email-dave.long@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434386579-6045-1-git-send-email-dave.long@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2006 Lines: 45 Hi David, On Mon, Jun 15, 2015 at 05:42:57PM +0100, David Long wrote: > From: "David A. Long" > > Move duplicate and functionally equivalent code for accessing registers > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > common kernel files. > > Note: Help regression testing s390, hexagon, and sh would be appreciated. > Powerpc builds but I have not verified the functionality. > > David A. Long (2): > Move the pt_regs_offset struct definition from arch to common include > file > Consolidate redundant register/stack access code > > arch/arm/include/asm/ptrace.h | 6 --- > arch/arm/kernel/ptrace.c | 72 +--------------------------------- > arch/hexagon/include/uapi/asm/ptrace.h | 3 -- > arch/powerpc/include/asm/ptrace.h | 38 ------------------ > arch/powerpc/kernel/ptrace.c | 39 +----------------- > arch/s390/include/asm/ptrace.h | 3 -- > arch/s390/kernel/ptrace.c | 70 ++++++++++----------------------- > arch/sh/include/asm/ptrace.h | 44 --------------------- > arch/sh/kernel/Makefile | 2 +- > arch/sh/kernel/ptrace.c | 33 ---------------- > arch/sh/kernel/ptrace_32.c | 2 +- > arch/sh/kernel/ptrace_64.c | 2 +- > arch/x86/include/asm/ptrace.h | 37 ----------------- > arch/x86/kernel/ptrace.c | 39 +----------------- > include/linux/ptrace.h | 51 ++++++++++++++++++++++++ > kernel/ptrace.c | 38 ++++++++++++++++++ > 16 files changed, 116 insertions(+), 363 deletions(-) Nice cleanup! The ARMy bits all look fine to me. Acked-by: Will Deacon Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/