Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754852AbbFPSSH (ORCPT ); Tue, 16 Jun 2015 14:18:07 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:35806 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbbFPSR6 (ORCPT ); Tue, 16 Jun 2015 14:17:58 -0400 From: Kevin Hilman To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger Subject: Re: [PATCH 5/5] ARM64: MediaTek MT8173: Add SCPSYS device node References: <1433839623-10804-1-git-send-email-s.hauer@pengutronix.de> <1433839623-10804-6-git-send-email-s.hauer@pengutronix.de> Date: Tue, 16 Jun 2015 11:17:53 -0700 In-Reply-To: <1433839623-10804-6-git-send-email-s.hauer@pengutronix.de> (Sascha Hauer's message of "Tue, 9 Jun 2015 10:47:03 +0200") Message-ID: <7hlhfjy0tq.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 38 Sascha Hauer writes: > This adds the SCPSYS device node to the MT8173 dtsi file. > > Signed-off-by: Sascha Hauer > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 924fdb6..12430f0 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -125,6 +125,16 @@ > ; > }; > > + scpsys: scpsys@10006000 { > + compatible = "mediatek,mt8173-scpsys"; > + #power-domain-cells = <1>; > + reg = <0 0x10006000 0 0x1000>; > + clocks = <&clk26m>, > + <&topckgen CLK_TOP_MM_SEL>; Neither your binding doc (nor the generic one) mentions these clock properties or what they are used for. They appear to define a clock that must be enabled in order to for the power domain to be on. Also the order here seems rather important and probably needs documenting in the binding (e.g. the clk_id order is hard-coded in the driver.) Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/