Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbbFPTEF (ORCPT ); Tue, 16 Jun 2015 15:04:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:55070 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752933AbbFPTDz (ORCPT ); Tue, 16 Jun 2015 15:03:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,627,1427785200"; d="scan'208";a="509341940" Date: Tue, 16 Jun 2015 12:00:46 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , Peter Zijlstra , Vikas Shivappa , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, Matt Fleming , "Juvva, Kanaka D" , "Williamson, Glenn P" , "Auld, Will" Subject: Re: [PATCH 01/10] cpumask: Introduce cpumask_any_online_but In-Reply-To: Message-ID: References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-2-git-send-email-vikas.shivappa@linux.intel.com> <20150615123614.GA3644@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 45 On Tue, 16 Jun 2015, Thomas Gleixner wrote: > On Mon, 15 Jun 2015, Vikas Shivappa wrote: >> On Mon, 15 Jun 2015, Peter Zijlstra wrote: >>> On Fri, Jun 12, 2015 at 11:17:08AM -0700, Vikas Shivappa wrote: >>>> + cpumask_and(&tmp, cpu_online_mask, mask); >>>> + cpumask_clear_cpu(cpu, &tmp); >>>> + return cpumask_any(&tmp); >>>> +} >>> >>> You had a good example in cpumask_any_but() copy that. >> >> I saw the cpumask_any_but but wanted to avoid the for loop in the >> cpumask_any_but , but now i see why from your previous comment. Without the >> cpumask_t I will have to use the cpumask_any_but .. the two were related. > > It can be done w/o a loop. Hint, you need a static cpumask in your > code anyway. Ah thats right, I always need the tmp mask. Confused this with avoiding the cpumask_clear_cpu line in the code vs. using cpumask_any_but. something like this just making it static then ? static cpumask_t tmp; cpumask_and(&tmp, cpu_online_mask, mask); cpumask_clear_cpu(cpu, &tmp); return cpumask_any(&tmp); Thanks, Vikas > > Thanks > > tglx > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/