Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757235AbbFPUII (ORCPT ); Tue, 16 Jun 2015 16:08:08 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:35395 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbbFPUIC (ORCPT ); Tue, 16 Jun 2015 16:08:02 -0400 Message-ID: <5580821D.4080408@cogentembedded.com> Date: Tue, 16 Jun 2015 23:07:57 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julien Grall , xen-devel@lists.xenproject.org CC: linux-kernel@vger.kernel.org, Wei Liu , Ian Campbell , netdev@vger.kernel.org Subject: Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format References: <1434481848-26387-1-git-send-email-julien.grall@citrix.com> <1434481848-26387-4-git-send-email-julien.grall@citrix.com> In-Reply-To: <1434481848-26387-4-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2263 Lines: 67 Hello. On 06/16/2015 10:10 PM, Julien Grall wrote: > Append 0x to all %x in order to avoid while reading when there is other > decimal value in the log. > Also replace some of the hexadecimal print to decimal to uniformize the > format with netfront. > Signed-off-by: Julien Grall > Cc: Wei Liu > Cc: Ian Campbell > Cc: netdev@vger.kernel.org > --- > Changes in v4: > - Patch added > --- > drivers/net/xen-netback/netback.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index ba3ae30..11bd9d8 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c [...] > @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct xenvif_queue *queue, > if (unlikely(queue->grant_tx_handle[pending_idx] != > NETBACK_INVALID_HANDLE)) { > netdev_err(queue->vif->dev, > - "Trying to overwrite active handle! pending_idx: %x\n", > + "Trying to overwrite active handle! pending_idx: 0x%x\n", Using "%#x" is shorter ind does the same. > pending_idx); > BUG(); > } > @@ -887,7 +887,7 @@ static inline void xenvif_grant_handle_reset(struct xenvif_queue *queue, > if (unlikely(queue->grant_tx_handle[pending_idx] == > NETBACK_INVALID_HANDLE)) { > netdev_err(queue->vif->dev, > - "Trying to unmap invalid handle! pending_idx: %x\n", > + "Trying to unmap invalid handle! pending_idx: 0x%x\n", Same here. [...] > @@ -1731,7 +1731,7 @@ void xenvif_idx_unmap(struct xenvif_queue *queue, u16 pending_idx) > &queue->mmap_pages[pending_idx], 1); > if (ret) { > netdev_err(queue->vif->dev, > - "Unmap fail: ret: %d pending_idx: %d host_addr: %llx handle: %x status: %d\n", > + "Unmap fail: ret: %d pending_idx: %d host_addr: %llx handle: 0x%x status: %d\n", And here. [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/