Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757259AbbFPUIi (ORCPT ); Tue, 16 Jun 2015 16:08:38 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:35175 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757009AbbFPUIb (ORCPT ); Tue, 16 Jun 2015 16:08:31 -0400 Message-ID: <5580821D.3050508@fb.com> Date: Tue, 16 Jun 2015 13:07:57 -0700 From: Josef Bacik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Hugh Dickins CC: Andrew Morton , , Subject: Re: [PATCH] tmpfs: truncate at i_size References: <1432049251-3298-1-git-send-email-jbacik@fb.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-16_06:2015-06-16,2015-06-16,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 27 On 06/16/2015 01:02 PM, Hugh Dickins wrote: > On Tue, 19 May 2015, Josef Bacik wrote: > >> If we fallocate past i_size with KEEP_SIZE, extend the file to use some but not >> all of this space, and then truncate(i_size) we won't trim the excess >> preallocated space. We decided at LSF that we want to truncate the fallocated >> bit past i_size when we truncate to i_size, which is what this patch does. >> Thanks, >> >> Signed-off-by: Josef Bacik > > Sorry for the delay, it's been on my mind but only now I get to it. > Yes, that was agreed at LSF, and I've checked that indeed tmpfs is > out of line here: thank you for fixing it. But I do prefer your > original more explicit description, so I'll send the patch to akpm > now for v4.2, with that description instead (plus a reference to LSF). > Sounds good, thanks Hugh. Josef -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/