From: Peter =?iso-8859-15?q?H=FCwe?= <PeterHuewe@gmx.de>
To: "Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>
Subject: Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq
Date: Tue, 16 Jun 2015 22:37:27 +0200
User-Agent: KMail/1.13.7 (Linux/4.1.0-rc6; KDE/4.14.3; x86_64; ; )
Cc: tpmdd-devel@lists.sourceforge.net, Ashley Lai <ashley@ashleylai.com>,
        Vicky Lo <honclo2014@gmail.com>, linux-kernel@vger.kernel.org,
        Joy Latten <jmlatten@linux.vnet.ibm.com>
References: <1432315382-11711-1-git-send-email-honclo@linux.vnet.ibm.com>
In-Reply-To: <1432315382-11711-1-git-send-email-honclo@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201506162237.28679.PeterHuewe@gmx.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1580
Lines: 47

Hey,

Am Freitag, 22. Mai 2015, 19:23:02 schrieb Hon Ching(Vicky) Lo:
> tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet
> set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq,
> the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address.
> 
> Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
> Signed-off-by: Joy Latten <jmlatten@linux.vnet.ibm.com>
> ---
>  drivers/char/tpm/tpm_ibmvtpm.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c
> b/drivers/char/tpm/tpm_ibmvtpm.c index 42ffa5e..27ebf95 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -578,6 +578,9 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
>  		goto cleanup;
>  	}
> 
> +	ibmvtpm->dev = dev;
> +	ibmvtpm->vdev = vio_dev;
> +
>  	crq_q = &ibmvtpm->crq_queue;
>  	crq_q->crq_addr = (struct ibmvtpm_crq *)get_zeroed_page(GFP_KERNEL);
>  	if (!crq_q->crq_addr) {
> @@ -622,8 +625,6 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> 
>  	crq_q->index = 0;
> 
> -	ibmvtpm->dev = dev;
> -	ibmvtpm->vdev = vio_dev;
>  	TPM_VPRIV(chip) = (void *)ibmvtpm;
> 
>  	spin_lock_init(&ibmvtpm->rtce_lock);

Is this a fix for something?
does it need to go through stable?

Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/