Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755659AbbFPVTw (ORCPT ); Tue, 16 Jun 2015 17:19:52 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:53750 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754227AbbFPVTo (ORCPT ); Tue, 16 Jun 2015 17:19:44 -0400 X-Helo: d23dlp03.au.ibm.com X-MailFrom: honclo@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq From: "Hon Ching (Vicky) Lo" To: Peter =?ISO-8859-1?Q?H=FCwe?= Cc: tpmdd-devel@lists.sourceforge.net, Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten In-Reply-To: <201506162237.28679.PeterHuewe@gmx.de> References: <1432315382-11711-1-git-send-email-honclo@linux.vnet.ibm.com> <201506162237.28679.PeterHuewe@gmx.de> Content-Type: text/plain; charset="UTF-8" Date: Tue, 16 Jun 2015 17:18:37 -0400 Message-ID: <1434489517.31047.1.camel@vtpm2014.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15061621-0017-0000-0000-000001657D2E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 56 Hi Peter, Yes, it's a fix to a kernel dump caused by enabling both vtpm and kdump. On Tue, 2015-06-16 at 22:37 +0200, Peter Hüwe wrote: > Hey, > > Am Freitag, 22. Mai 2015, 19:23:02 schrieb Hon Ching(Vicky) Lo: > > tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet > > set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq, > > the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address. > > > > Signed-off-by: Hon Ching(Vicky) Lo > > Signed-off-by: Joy Latten > > --- > > drivers/char/tpm/tpm_ibmvtpm.c | 5 +++-- > > 1 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c > > b/drivers/char/tpm/tpm_ibmvtpm.c index 42ffa5e..27ebf95 100644 > > --- a/drivers/char/tpm/tpm_ibmvtpm.c > > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > > @@ -578,6 +578,9 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > > goto cleanup; > > } > > > > + ibmvtpm->dev = dev; > > + ibmvtpm->vdev = vio_dev; > > + > > crq_q = &ibmvtpm->crq_queue; > > crq_q->crq_addr = (struct ibmvtpm_crq *)get_zeroed_page(GFP_KERNEL); > > if (!crq_q->crq_addr) { > > @@ -622,8 +625,6 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > > > > crq_q->index = 0; > > > > - ibmvtpm->dev = dev; > > - ibmvtpm->vdev = vio_dev; > > TPM_VPRIV(chip) = (void *)ibmvtpm; > > > > spin_lock_init(&ibmvtpm->rtce_lock); > > Is this a fix for something? > does it need to go through stable? > > Thanks, > Peter > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/