Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932248AbbFPWYw (ORCPT ); Tue, 16 Jun 2015 18:24:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33198 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754883AbbFPWYT (ORCPT ); Tue, 16 Jun 2015 18:24:19 -0400 From: Stephane Viau To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, Stephane Viau Subject: [RFC 1/2] [RFC] drm/msm/hdmi: remove ->reset() from HDMI PHY Date: Tue, 16 Jun 2015 18:24:08 -0400 Message-Id: <1434493449-10314-2-git-send-email-sviau@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1434493449-10314-1-git-send-email-sviau@codeaurora.org> References: <1434493449-10314-1-git-send-email-sviau@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 36 ->reset() currently only accesses HDMI core registers, and yet it is located in hdmi_phy*. Since no PHY registers are being accessed during ->reset(), it would be better to bring that function in hdmi core module where HDMI core registers are usually being accessed. This will also help for msm8x94 for which no PHY registers accesses are done (->phy_init == NULL) but the HDMI PHY reset from HDMI core still needs to be done. Note: SW_RESET_PLL bit is not written in hdmi_phy_8x60_reset(); this write should not affect anything if the corresponding field is not writable. Signed-off-by: Stephane Viau --- drivers/gpu/drm/msm/hdmi/hdmi.h | 1 - drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 51 ++++++++++++++++++++++++++- drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 52 ---------------------------- drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 32 ----------------- drivers/gpu/drm/msm/hdmi/hdmi_phy_8x74.c | 57 ------------------------------- 5 files changed, 50 insertions(+), 143 deletions(-) -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/