Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757189AbbFQBSG (ORCPT ); Tue, 16 Jun 2015 21:18:06 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:35571 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbFQBR7 (ORCPT ); Tue, 16 Jun 2015 21:17:59 -0400 From: Ashley Lai X-Google-Original-From: Ashley Lai Date: Tue, 16 Jun 2015 20:17:56 -0500 (CDT) To: "Hon Ching(Vicky) Lo" cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten Subject: Re: [PATCH v2 1/2] vTPM: support little endian guests In-Reply-To: <1433901293-29352-1-git-send-email-honclo@linux.vnet.ibm.com> Message-ID: References: <1433901293-29352-1-git-send-email-honclo@linux.vnet.ibm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 27 Just a small comment otherwise it looks good. On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: > case NONHOST_INFO: > - name = tcpa_event_type_strings[event->event_type]; > + name = > + tcpa_event_type_strings[do_endian_conversion > + (event->event_type)]; Not being picky but if it does not exceed 80 characters it looks better to join the line above. name = tcpa_event_type_strings[do_endian_conversion (event->event_type)]; > case POST_CONTENTS: > - name = tcpa_pc_event_id_strings[pc_event->event_id]; > + name = > + tcpa_pc_event_id_strings[do_endian_conversion > + (pc_event->event_id)]; Same as above. Thanks, --Ashley Lai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/