Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757466AbbFQBVG (ORCPT ); Tue, 16 Jun 2015 21:21:06 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:36497 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbbFQBU5 (ORCPT ); Tue, 16 Jun 2015 21:20:57 -0400 From: Ashley Lai X-Google-Original-From: Ashley Lai Date: Tue, 16 Jun 2015 20:20:55 -0500 (CDT) To: "Hon Ching(Vicky) Lo" cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten Subject: Re: [PATCH v2 2/2] TPM: remove unnecessary little endian conversion In-Reply-To: <1433901293-29352-2-git-send-email-honclo@linux.vnet.ibm.com> Message-ID: References: <1433901293-29352-1-git-send-email-honclo@linux.vnet.ibm.com> <1433901293-29352-2-git-send-email-honclo@linux.vnet.ibm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1644 Lines: 54 Looks good. Reviewed-by: Ashley Lai Thanks, --Ashley On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: > The base pointer for the event log is allocated in the local > kernel (in prom_instantiate_sml()), therefore it is already in > the host's endian byte order and requires no conversion. > > The content of the 'basep' pointer in read_log() stores the > base address of the log. This patch ensures that it is correctly > implemented. > > Signed-off-by: Hon Ching(Vicky) Lo > Signed-off-by: Joy Latten > --- > drivers/char/tpm/tpm_of.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c > index c002d1b..62a22ce 100644 > --- a/drivers/char/tpm/tpm_of.c > +++ b/drivers/char/tpm/tpm_of.c > @@ -24,7 +24,7 @@ int read_log(struct tpm_bios_log *log) > { > struct device_node *np; > const u32 *sizep; > - const __be64 *basep; > + const u64 *basep; > > if (log->bios_event_log != NULL) { > pr_err("%s: ERROR - Eventlog already initialized\n", __func__); > @@ -63,7 +63,7 @@ int read_log(struct tpm_bios_log *log) > > log->bios_event_log_end = log->bios_event_log + *sizep; > > - memcpy(log->bios_event_log, __va(be64_to_cpup(basep)), *sizep); > + memcpy(log->bios_event_log, __va(*basep), *sizep); > > return 0; > > -- > 1.7.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/