Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757530AbbFQBbo (ORCPT ); Tue, 16 Jun 2015 21:31:44 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:3634 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbbFQBbf (ORCPT ); Tue, 16 Jun 2015 21:31:35 -0400 Message-ID: <5580CDE4.4090300@huawei.com> Date: Wed, 17 Jun 2015 09:31:16 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Joe Perches CC: , , , , , , , , , , , Subject: Re: [PATCH 2/2] apei/erst-dbg: Define pr_fmt macro to avoid the duplication of ERST_DBG_PFX References: <1434362250-217135-1-git-send-email-long.wanglong@huawei.com> <1434362250-217135-2-git-send-email-long.wanglong@huawei.com> <1434379353.2507.52.camel@perches.com> In-Reply-To: <1434379353.2507.52.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.88.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 31 On 2015/6/15 22:42, Joe Perches wrote: > On Mon, 2015-06-15 at 09:57 +0000, Wang Long wrote: >> Define pr_fmt macro with {ERST DBG: } prefix, then remove all use >> of ERST_DBG_PFXin the pr_* functions. > [] >> diff --git a/drivers/acpi/apei/erst-dbg.c b/drivers/acpi/apei/erst-dbg.c > [] >> @@ -31,7 +31,8 @@ >> >> #include "apei-internal.h" >> >> -#define ERST_DBG_PFX "ERST DBG: " >> +#undef pr_fmt >> +#define pr_fmt(fmt) "ERST DBG: " fmt > > Moving this #define above the first #include is what's > generally done and doesn't require an #undef > OK, Thanks > > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/