Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbbFQEOK (ORCPT ); Wed, 17 Jun 2015 00:14:10 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:35367 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbbFQEOD (ORCPT ); Wed, 17 Jun 2015 00:14:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150616145552.GH30522@arm.com> References: <1434465343-29124-1-git-send-email-djkurtz@chromium.org> <20150616145552.GH30522@arm.com> From: Daniel Kurtz Date: Wed, 17 Jun 2015 12:13:41 +0800 X-Google-Sender-Auth: 2WvMivCt9mwettVhgtiqSeaqICI Message-ID: Subject: Re: [PATCH] arm64: dts: symlink cros-ec-keyboard from arm to arm64 To: Will Deacon Cc: "linux-mediatek@lists.infradead.org" , Nicolas Boichat , Olof Johansson , Eddie Huang , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , "open list:OPEN FIRMWARE AND..." , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 53 On Tue, Jun 16, 2015 at 10:55 PM, Will Deacon wrote: > On Tue, Jun 16, 2015 at 03:35:41PM +0100, Daniel Kurtz wrote: >> The cros-ec-keyboard.dtsi snippet is useful for both arm and arm64 boards. >> Create a link between the two. >> >> This may not be the most scalable solution, so consider it temporary until >> we find a more central repository for such shared .dtsi snippets. > > I don't have strong opinions either way, but we should be consistent as > to whether we use relative paths: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/350267.html > > or symlinks, like below. > > Does anybody have some technical arguments one way or the other? /include/ "../../../../arm/boot/dts/cros-ec-keyboard.dtsi" Directly embedding the relative path to .dtsi in /arm/ from .dts in /arm64/ is more straightforward and does not require maintaining extra symlink .dtsi files. I actually like it better than the symlink that I proposed :-). Consider my patch abandoned, unless someone else feels strongly. -Dan > > Will > >> Signed-off-by: Daniel Kurtz >> --- >> arch/arm64/boot/dts/cros-ec-keyboard.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> create mode 120000 arch/arm64/boot/dts/cros-ec-keyboard.dtsi >> >> diff --git a/arch/arm64/boot/dts/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi >> new file mode 120000 >> index 0000000..42220ac >> --- /dev/null >> +++ b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi >> @@ -0,0 +1 @@ >> +../../../arm/boot/dts/cros-ec-keyboard.dtsi >> \ No newline at end of file >> -- >> 2.2.0.rc0.207.ga3a616c >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/