Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130AbbFQFEY (ORCPT ); Wed, 17 Jun 2015 01:04:24 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:37902 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbbFQFEO (ORCPT ); Wed, 17 Jun 2015 01:04:14 -0400 X-AuditID: cbfee690-f796f6d000005054-24-5580ffccbe14 Date: Wed, 17 Jun 2015 05:04:12 +0000 (GMT) From: Maninder Singh Subject: Re: Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON() To: David Miller Cc: "willemb@google.com" , "dborkman@redhat.com" , "al.drozdov@gmail.com" , "viro@zeniv.linux.org.uk" , "eyal.birger@gmail.com" , "mst@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , PANKAJ MISHRA Reply-to: maninder1.s@samsung.com MIME-version: 1.0 X-MTR: 20150617050139865@maninder1.s Msgkey: 20150617050139865@maninder1.s X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150617050139865@maninder1.s X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <405153159.1166061434517448384.JavaMail.weblogic@epmlwas03c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsWyRsSkSvfM/4ZQg8v/NS0u75rD5sDo8XmT XABjFJdNSmpOZllqkb5dAlfG/5VLWQreMVdM+X+OtYHxDnMXIyeHkICaxKK9j9m6GDk4JARM JH7OVQYJSwiISVy4tx4ozAVUspRR4seKN+wQCROJPU1XWCAScxgl3r5bwwSSYBFQlWg7uhBs KJuAvsTZveuYQYYKCzhI/J5tAxIWEdCQ+LjrJSNIL7PAHmaJby33GSGOUJRYf+MJmM0rIChx cuYTFohlKhI7f/9ggYirSrxZ+IANIi4nsWTqZSYIm1diRvtTFpj4tK9rmCFsaYnzszYwwnyz +PtjqDi/xLHbO6B6BSSmnjkIVaMpcbntB5TNJ7Fm4VsWmPpdp5Yzw+y6v2UuVK+ExNaWJ6wg NjPQ/VO6H7JD2AYSRxbNYUX3C6+Ah8TrljPsIM9LCPRySPy/soJ5AqPSLCR1s5DMmoVkFrKa BYwsqxhFUwuSC4qT0otM9IoTc4tL89L1kvNzNzECU8Ppf88m7GC8d8D6EKMAB6MSD++GRw2h QqyJZcWVuYcYTYHxNJFZSjQ5H5iA8kriDY3NjCxMTUyNjcwtzZTEeV9L/QwWEkhPLEnNTk0t SC2KLyrNSS0+xMjEwSnVwDj1y82Dp54vTWla/XtvsBPnxEl+IexG6nnC73QMnU6LrOt7+rDI 5CGT1I7JD/ccVb3Hmp3Id02T402nyJza10zuk903LrnFXBhu/lv3ODOH6zP1Hn9mo33sP2bd vz9tURCTVev8z+8a1txoaDLlEy+6sWbu05VCticmCv/cVfpYvfZoWLbIym9KLMUZiYZazEXF iQANBchdCAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOKsWRmVeSWpSXmKPExsVy+t/tft0z/xtCDWY0KVhc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q9NYK0MDAyNToJqEtIz/ K5eyFLxjrpjy/xxrA+Md5i5GTg4hATWJRXsfs4HYEgImEnuarrBA2GISF+6tB4pzAdXMYZR4 +24NE0iCRUBVou3oQrBmNgF9ibN71wHZHBzCAg4Sv2fbgIRFBDQkPu56yQjSyyywh1niW8t9 RohlihLrbzwBs3kFBCVOznwCtUxFYufvHywQcVWJNwsfQB0kJ7Fk6mUmCJtXYkb7UxaY+LSv a5ghbGmJ87M2MMIcvfj7Y6g4v8Sx2zugegUkpp45CFWjKXG57QeUzSexZuFbFpj6XaeWM8Ps ur9lLlSvhMTWliesIDYz0P1Tuh+yQ9gGEkcWzWFF9wuvgIfE65Yz7BMYZWchSc1C0j4LSTuy mgWMLKsYRVMLkguKk9IrjPSKE3OLS/PS9ZLzczcxghPRs0U7GP+dtz7EKMDBqMTDu+FRQ6gQ a2JZcWXuIUYJDmYlEV7l70Ah3pTEyqrUovz4otKc1OJDjKbAWJvILCWanA9Mknkl8YbGJuam xqYWBobm5mZK4rz/z+WGCAmkJ5akZqemFqQWwfQxcXBKNTA6t5xZ+Sg4beG6xE+xSXobZ+iy Pd0vbm7fyrnsLn+Acmuf6bI5pRGeJzp/G24vmXHT62dmZ+HcWxsv3NNg6DhqNqXN1eDVumdO /ztSn0qeOBTx1PnUxWt3NSzc30iJq374lveRg+Prjid54btl0hv8Dsv1WZw4pHYhYZMnp0vQ 7rqo6f55s1crsRRnJBpqMRcVJwIALHuFGloDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5H54TmP007226 Content-Length: 505 Lines: 12 Hi David, >> Use BUG_ON(condition) instead of if(condition)/BUG() >> >> Signed-off-by: Maninder Singh >> Reviewed-by: Akhilesh Kumar >Your email client corrupted this patch, making it unusable I resent the patch with git send-mail , it results ok, hopefully it does not corrupt it. Thanks????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?