Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754700AbbFQGyB (ORCPT ); Wed, 17 Jun 2015 02:54:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40392 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbbFQGxw (ORCPT ); Wed, 17 Jun 2015 02:53:52 -0400 Subject: Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch From: Jean Delvare To: Nicolai Stange Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Karsten Keil , "David S. Miller" In-Reply-To: <87pp4vw3ep.fsf@gmail.com> References: <87pp4vw3ep.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Organization: Suse Linux Date: Wed, 17 Jun 2015 08:53:49 +0200 Message-ID: <1434524029.4280.12.camel@chaos.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2415 Lines: 56 Le Wednesday 17 June 2015 à 03:05 +0200, Nicolai Stange a écrit : > Fix an allmodconfig compilation failer on microblaze due to big endian > architectures being apparently unsupported by the NetJet code: > drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s': > drivers/isdn/hisax/nj_s.c:265:2: > error: #error "not running on big endian machines now" > > Modify the relevant Kconfig such that the NetJet code is not built on > microblaze anymore. > > Note that endianess on microblaze is not determined through Kconfig, > but by means of a compiler provided CPP macro, namely __MICROBLAZEEL__. > However, gcc defaults to big endianess on that platform. > > Signed-off-by: Nicolai Stange > --- > The maintainer tree listed under "ISDN SUBSYSTEM" in MAINTAINERS does > not exist anymore. I created the diff against the Linus tree. > > drivers/isdn/hisax/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig > index 97465ac..eb83d94 100644 > --- a/drivers/isdn/hisax/Kconfig > +++ b/drivers/isdn/hisax/Kconfig > @@ -237,7 +237,7 @@ config HISAX_MIC > > config HISAX_NETJET > bool "NETjet card" > - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE)) > depends on VIRT_TO_BUS > help > This enables HiSax support for the NetJet from Traverse > @@ -249,7 +249,7 @@ config HISAX_NETJET > > config HISAX_NETJET_U > bool "NETspider U card" > - depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || MICROBLAZE)) > depends on VIRT_TO_BUS > help > This enables HiSax support for the Netspider U interface ISDN card Acked-by: Jean Delvare -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/