Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757910AbbFQHhu (ORCPT ); Wed, 17 Jun 2015 03:37:50 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50282 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757670AbbFQHhk (ORCPT ); Wed, 17 Jun 2015 03:37:40 -0400 Date: Wed, 17 Jun 2015 09:37:34 +0200 From: Boris Brezillon To: Herbert Xu Cc: "David S. Miller" , linux-crypto@vger.kernel.org, Arnaud Ebalard , Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Imre Kaloz Subject: Re: [PATCH v5 05/14] crypto: marvell/CESA: add TDMA support Message-ID: <20150617093734.03f84134@bbrezillon> In-Reply-To: <20150617071829.GA9895@gondor.apana.org.au> References: <1434448748-10828-1-git-send-email-boris.brezillon@free-electrons.com> <1434448748-10828-6-git-send-email-boris.brezillon@free-electrons.com> <20150617050527.GA8807@gondor.apana.org.au> <20150617055633.GA9123@gondor.apana.org.au> <20150617091503.5f74b6e5@bbrezillon> <20150617071829.GA9895@gondor.apana.org.au> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 31 On Wed, 17 Jun 2015 15:18:29 +0800 Herbert Xu wrote: > On Wed, Jun 17, 2015 at 09:15:03AM +0200, Boris Brezillon wrote: > > > > Anyway, now I'm doing the following test: > > > > if (creq->src_nents && !ret) > > return -ENOMEM; > > Best not call dma_map_sg at all in the !src_nents case as I think > some architectures will WARN or BUG if you give it a zero-length > list. Okay, I've changed it to test for the !src_nents before calling dma_map_sg. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/