Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754285AbbFQITz (ORCPT ); Wed, 17 Jun 2015 04:19:55 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38146 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbbFQITs (ORCPT ); Wed, 17 Jun 2015 04:19:48 -0400 MIME-Version: 1.0 In-Reply-To: <1434555974-16352-1-git-send-email-gongzhaogang@inspur.com> References: <1434555974-16352-1-git-send-email-gongzhaogang@inspur.com> Date: Wed, 17 Jun 2015 10:19:47 +0200 Message-ID: Subject: Re: [PATCH] Hotplug: fix the bug that the system is down,when memory is not in node0 and cpu is logically hotadded. From: Frans Klaver To: gongzg Cc: tj@kernel.org, "linux-kernel@vger.kernel.org" , SongXiumiao Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2650 Lines: 72 On Wed, Jun 17, 2015 at 5:46 PM, gongzg wrote: > From: GongZhaogang > > By analysing the bug function call trace,we find that create_worker function > will alloc the memory from node0.Because node0 is offline,the allocation is > failed.Then we add a condition to ensure the node is online and > system can alloc memory from a node that is online. > > Follow is the bug information: > > Signed-off-by: SongXiumiao I still think you should add at least one space after your periods and commas, and that you should be able to shorten your subject line. Explain the exact bug in your commit message. I also just noticed that the From/Signed-off-by names and emails don't match. If SongXiumiao wrote the patch, From: should contain that name and email. And since you are sending it, you will have to add your sign-off as well. So here's a suggestion of how your commit message could look: Subject: [PATCH] hotplug: fix oops when adding cpu From: SongXiumiao If memory is not in node0 and a cpu is logically hotadded, the kernel oopses ... By analyzing ... Here's the backtrace: ... Signed-off-by: SongXiumiao Signed-off-by: GongZhaogang Thanks, Frans > --- > kernel/workqueue.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 586ad91..22d194c 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -3253,7 +3253,8 @@ static struct worker_pool *get_unbound_pool(const struct workqueue_attrs *attrs) > if (wq_numa_enabled) { > for_each_node(node) { > if (cpumask_subset(pool->attrs->cpumask, > - wq_numa_possible_cpumask[node])) { > + wq_numa_possible_cpumask[node]) > + && node_online(node)) { > pool->node = node; > break; > } > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/