Message-ID: <1434531244.2069.111.camel@x220>
Subject: Re: [PATCH] driver/i2c/mux: Add register based mux i2c-mux-reg
From: Paul Bolle <pebolle@tiscali.nl>
To: York Sun <yorksun@freescale.com>
Cc: wsa@the-dreams.de, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Peter Korsgaard <peter.korsgaard@barco.com>
Date: Wed, 17 Jun 2015 10:54:04 +0200
In-Reply-To: <1434475692-4611-1-git-send-email-yorksun@freescale.com>
References: <1434475692-4611-1-git-send-email-yorksun@freescale.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 40

A nit and a question follow.

On Tue, 2015-06-16 at 10:28 -0700, York Sun wrote:
> --- /dev/null
> +++ b/drivers/i2c/muxes/i2c-mux-reg.c

> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

According to include/linux/module.h this sates the license is GPL v2 or
later. So I think that either the comment at the top of this file or the
ident used in the MODULE_LICENSE() macro needs to change.

> +MODULE_ALIAS("platform:i2c-mux-reg");

As far as I understand it, this alias is only useful if there's a
corresponding struct platform_device, somewhere. Ie, this alias needs a
platform_device that will fire of a "MODALIAS=platform:i2c-mux-reg"
uevent when it's created. (I don't know exactly how all that works, so
I'm handwaving quite a bit here.) That would be platform_device with a
"i2c-mux-reg" name.

Did I get this right? Because then I think this MODULE_ALIAS() isn't
needed, as I couldn't find such a corresponding platform_device.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/