Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753602AbbFQJRR (ORCPT ); Wed, 17 Jun 2015 05:17:17 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34768 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819AbbFQJRJ (ORCPT ); Wed, 17 Jun 2015 05:17:09 -0400 Date: Wed, 17 Jun 2015 11:17:04 +0200 From: Ingo Molnar To: Riku Voipio , Rusty Russell , Stephen Rothwell Cc: Peter Zijlstra , mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, "Paul E. McKenney" Subject: [PATCH] tools/perf, rbtree: Add RCU wrappers to make rbtree.h usable in user-space Message-ID: <20150617091703.GA2883@gmail.com> References: <20150617060952.GA5375@kos.to> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150617060952.GA5375@kos.to> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2109 Lines: 66 * Riku Voipio wrote: > Hi, > > The commit: > > commit d72da4a4d973d8a0a0d3c97e7cdebf287fbe3a99 > Author: Peter Zijlstra > Date: Wed May 27 11:09:36 2015 +0930 > > rbtree: Make lockless searches non-fatal > > Adds to rbtree.h, which in turn is included from perf userspace > headers. Now building tools/perf will fail with hundreds of lines of gcc complaining > about kernel defines not available. Reverting the patch makes perf build again. > This is with gcc-4.9 from debian but I don't think it's compiler specific. Does the patch below make things work? This fix could go into the modules tree, as this commit came via Rusty. Stephen, feel free to add: make -C tools/perf to the linux-next build tests. It's always supposed to build without failure, in pretty much whatever x86 distro you run your build tests on. Thanks, Ingo ===================> >From 62c251255f07ede8efa356d4ea9ab51827ffa0d0 Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Wed, 17 Jun 2015 11:07:11 +0200 Subject: [PATCH] tools/perf, rbtree: Add RCU wrappers to make rbtree.h usable in user-space Reported-by: Riku Voipio Signed-off-by: Ingo Molnar --- tools/perf/util/include/linux/rcupdate.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/perf/util/include/linux/rcupdate.h b/tools/perf/util/include/linux/rcupdate.h new file mode 100644 index 000000000000..3e022dd9a69b --- /dev/null +++ b/tools/perf/util/include/linux/rcupdate.h @@ -0,0 +1,9 @@ +#ifndef PERF_LINUX_RCUPDATE_H_ +#define PERF_LINUX_RCUPDATE_H_ + +/* Simple trivial wrappers for now, we don't use RCU in perf user-space (yet): */ +#define WRITE_ONCE(var, val) ((var) = (val)) +#define rcu_assign_pointer(ptr, val) WRITE_ONCE(ptr, val) + +#endif + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/