Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbbFQJbQ (ORCPT ); Wed, 17 Jun 2015 05:31:16 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:2020 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbbFQJbF (ORCPT ); Wed, 17 Jun 2015 05:31:05 -0400 X-IronPort-AV: E=Sophos;i="5.13,632,1427760000"; d="scan'208";a="275665756" Message-ID: <55813E3F.8030602@citrix.com> Date: Wed, 17 Jun 2015 10:30:39 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ian Campbell CC: , , Wei Liu , Subject: Re: [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format References: <1434481848-26387-1-git-send-email-julien.grall@citrix.com> <1434481848-26387-4-git-send-email-julien.grall@citrix.com> <1434533143.13744.273.camel@citrix.com> In-Reply-To: <1434533143.13744.273.camel@citrix.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 40 Hi Ian, On 17/06/2015 10:25, Ian Campbell wrote: > On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote: >> Append 0x to all %x in order to avoid while reading when there is other >> decimal value in the log. >> >> Also replace some of the hexadecimal print to decimal to uniformize the >> format with netfront. >> >> Signed-off-by: Julien Grall >> Cc: Wei Liu >> Cc: Ian Campbell >> Cc: netdev@vger.kernel.org > > You meant s/Append/Prepend/, nonetheless: I noticed a missing word after "avoid" in the commit message too. I will update to: "Prepend 0x to all %x in order to avoid confusion while reading when there is other decimal value in the log. [...]". > > Acked-by: Ian Campbell I see different opinion on whether using 0x% or %#. As I plan to resend a version with the commit message update, shall I use %#? Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/