Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755255AbbFQLjv (ORCPT ); Wed, 17 Jun 2015 07:39:51 -0400 Received: from smtp.citrix.com ([66.165.176.89]:15075 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932396AbbFQLjf (ORCPT ); Wed, 17 Jun 2015 07:39:35 -0400 X-IronPort-AV: E=Sophos;i="5.13,632,1427760000"; d="scan'208";a="272818953" From: Julien Grall To: CC: , Julien Grall , David Vrabel , Konrad Rzeszutek Wilk , Boris Ostrovsky , Subject: [PATCH v5 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Date: Wed, 17 Jun 2015 12:38:21 +0100 Message-ID: <1434541103-31114-2-git-send-email-julien.grall@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1434541103-31114-1-git-send-email-julien.grall@citrix.com> References: <1434541103-31114-1-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 45 rx->status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. Also use %u rather than %x for rx->offset. Signed-off-by: Julien Grall Reviewed-by: David Vrabel Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: netdev@vger.kernel.org --- Changes in v4: - Use %u for the rx->offset because offset is unsigned Changes in v3: - Use %d for the rx->offset too. Changes in v2: - Add David's Reviewed-by --- drivers/net/xen-netfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index e031c94..281720f 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue, if (unlikely(rx->status < 0 || rx->offset + rx->status > PAGE_SIZE)) { if (net_ratelimit()) - dev_warn(dev, "rx->offset: %x, size: %u\n", + dev_warn(dev, "rx->offset: %u, size: %d\n", rx->offset, rx->status); xennet_move_rx_slot(queue, skb, ref); err = -EINVAL; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/