Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbbFQLyy (ORCPT ); Wed, 17 Jun 2015 07:54:54 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:56523 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbbFQLyq (ORCPT ); Wed, 17 Jun 2015 07:54:46 -0400 Message-ID: <55815FEE.7080800@huawei.com> Date: Wed, 17 Jun 2015 19:54:22 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Namhyung Kim CC: Jiri Olsa , Arnaldo Carvalho de Melo , Ingo Molnar , Li Zefan , , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH tip] perf tools: Fix a compiling problem References: <1433321426-170133-1-git-send-email-wangnan0@huawei.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 50 Please note that a similar patch has been applied by Arnaldo Carvalho de Melo: http://lkml.kernel.org/r/20150616134750.GC10374@kernel.org On 2015/6/3 20:30, Namhyung Kim wrote: > Hi Wang, > > On Wed, Jun 3, 2015 at 5:50 PM, Wang Nan wrote: >> Commit 4bb11d012ab248d0e383008d725be0d26a74fac2 ("perf tools: Add >> dso__data_get/put_fd()") has a problem: it uses a undefined variable >> 'dso' in find_proc_info(), which should be 'map->dso'. The buggy code >> piece is not compiled if NO_LIBUNWIND_DEBUG_FRAME is not set. >> >> Signed-off-by: Wang Nan > Acked-by: Namhyung Kim > > Thanks for fixing this! > Namhyung > > >> --- >> tools/perf/util/unwind-libunwind.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c >> index f079b63..4c00507 100644 >> --- a/tools/perf/util/unwind-libunwind.c >> +++ b/tools/perf/util/unwind-libunwind.c >> @@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi, >> unw_word_t base = is_exec ? 0 : map->start; >> >> if (fd >= 0) >> - dso__data_put_fd(dso); >> + dso__data_put_fd(map->dso); >> >> memset(&di, 0, sizeof(di)); >> if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name, >> -- >> 1.8.3.4 >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/