Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941AbbFQMAP (ORCPT ); Wed, 17 Jun 2015 08:00:15 -0400 Received: from conuserg011.nifty.com ([202.248.44.37]:45992 "EHLO conuserg011-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753605AbbFQMAD (ORCPT ); Wed, 17 Jun 2015 08:00:03 -0400 X-Nifty-SrcIP: [106.178.177.36] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Cc: Masahiro Yamada , Linus Walleij , Alexandre Courbot , linux-kernel@vger.kernel.org, Tien Hock Loh Subject: [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove() Date: Wed, 17 Jun 2015 20:59:43 +0900 Message-Id: <1434542383-21314-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com> References: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 34 The remove callback never succeeds, which seems odd. Signed-off-by: Masahiro Yamada --- I wonder why nobody has pointed this out before me. I am suspecting -EIO might be intentional. I hope some Altera guys will give me comments. drivers/gpio/gpio-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index c653c83..5861550 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -339,7 +339,7 @@ static int altera_gpio_remove(struct platform_device *pdev) of_mm_gpiochip_remove(&altera_gc->mmchip); - return -EIO; + return 0; } static const struct of_device_id altera_gpio_of_match[] = { -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/