Message-ID: <55816455.1030503@st.com>
Date: Wed, 17 Jun 2015 14:13:09 +0200
From: Maxime Coquelin <maxime.coquelin@st.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Fabien Dessenne <fabien.dessenne@st.com>,
        Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
        Patrice Chotard <patrice.chotard@st.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        <linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCH] ARM: DT: STiH410: Add bdisp dt nodes
References: <1434461440-3965-1-git-send-email-fabien.dessenne@st.com>
In-Reply-To: <1434461440-3965-1-git-send-email-fabien.dessenne@st.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1454
Lines: 50

Hi Fabien,

On 06/16/2015 03:30 PM, Fabien Dessenne wrote:
> Add the bdisp (2D blitter for STMicroelectronics SoC) dt nodes for the
> first of the two bdisp devices, defining register address, interrupt and
> clock.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
>   arch/arm/boot/dts/stih410.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
> index 208b5e8..6f40bc9 100644
> --- a/arch/arm/boot/dts/stih410.dtsi
> +++ b/arch/arm/boot/dts/stih410.dtsi
> @@ -10,6 +10,10 @@
>   #include "stih407-family.dtsi"
>   #include "stih410-pinctrl.dtsi"
>   / {
> +	aliases {
> +		bdisp0 = &bdisp0;
> +	};
> +
>   	soc {
>   		usb2_picophy1: phy2 {
>   			compatible = "st,stih407-usb2-phy";
> @@ -218,5 +222,13 @@
>   				};
>   			};
>   		};
> +
> +		bdisp0:bdisp@9f10000 {
> +			compatible = "st,stih407-bdisp";
> +			reg = <0x9f10000 0x1000>;
> +			interrupts = <GIC_SPI 38 IRQ_TYPE_NONE>;
> +			clock-names = "bdisp";
> +			clocks = <&clk_s_c0_flexgen CLK_IC_BDISP_0>;
> +		};

Isn't the bdisp also present on STiH407 SoC?
If so, could you please move this node to stih407-family file?

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/