Date: Wed, 17 Jun 2015 14:09:33 +0100
From: Mark Brown <broonie@kernel.org>
To: Sagar Dharia <sdharia@codeaurora.org>
Cc: gregkh@linuxfoundation.org, bp@suse.de, poeschel@lemonage.de,
        treding@nvidia.com, gong.chen@linux.intel.com,
        andreas.noever@gmail.com, alan@linux.intel.com,
        mathieu.poirier@linaro.org, daniel@ffwll.ch, oded.gabbay@amd.com,
        jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com,
        davem@davemloft.net, james.hogan@imgtec.com,
        michael.opdenacker@free-electrons.com, daniel.thompson@linaro.org,
        linux-kernel@vger.kernel.org, nkaje@codeaurora.org,
        kheitke@audience.com, mlocke@codeaurora.org, agross@codeaurora.org,
        linux-arm-msm@vger.kernel.org
Message-ID: <20150617130932.GF3214@sirena.org.uk>
References: <1434505564-14333-1-git-send-email-sdharia@codeaurora.org>
 <1434505564-14333-3-git-send-email-sdharia@codeaurora.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Il7n/DHsA0sMLmDu"
Content-Disposition: inline
In-Reply-To: <1434505564-14333-3-git-send-email-sdharia@codeaurora.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [PATCH V2 2/6] of/slimbus: OF helper for SLIMbus
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2191
Lines: 57


--Il7n/DHsA0sMLmDu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 16, 2015 at 07:46:00PM -0600, Sagar Dharia wrote:
> OF helper routine scans the SLIMbus DeviceTree, allocates resources,
> and creates slim_devices according to the hierarchy.

You've not CCed any of the DT maintainers on this, for a completely new
bus it seems like we really ought to get their input.

> @@ -0,0 +1,34 @@
> +SLIM(Serial Low Power Interchip Media Bus) bus
> +
> +SLIMbus is a 2-wire bus, and is used to communicate with peripheral
> +components like audio-codec.
> +
> +Required property for SLIMbus controller node:
> +- compatible	- name of SLIMbus controller.
> +
> +No other properties are required in the SLIMbus controller bus node.

It seems better to just say that the controller is a normal device using
the binding for whatever bus it is on and that the binding is for the
bus which is a child node of the controller device?  Also, do we need
#address-cells or #size-cells here?

> +Required property for SLIMbus child node:
> +enumeration-addr	- 6 byte enumeration address of the slave

The idiom for DT seems to be that we define the bus address using the
reg property.  Should we not be following that pattern here too?  I'd
also expect to see the ability to define a compatible for the slaves.

--Il7n/DHsA0sMLmDu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVgXGMAAoJECTWi3JdVIfQN2gH/0pLhWKfhyOgXBSGhpaqGPjQ
z7VhLJCz/ZtIIapQAkl+5xO6H1k+Z1FoikZrc+X+28S9cBBDGTDmNJ4HC1oSjDlZ
6REwz8r2/zymYRWBAE+orOE8dNfpr22QiJIC7w/TpjXgco9jYo3xiNko+dnkcQpA
L5T8dIBNh3TdsKEErpc+N69c9SJDwWnqLAbbMnoZXQpoxI/f+md3PlK8BWJQPmz2
uUS0zRRrADdMsrcFDdCPympPyvwbHYNNAwHOCj+t08g5QhNNuBgJtppMBslFiY9R
wKlA1uAULKwN5e8haJdOq35PVWVy2V50u1rVHyag47uLgnwd4wpA/0yC0H46yj0=
=ir+a
-----END PGP SIGNATURE-----

--Il7n/DHsA0sMLmDu--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/