Date: Wed, 17 Jun 2015 15:13:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH 3/5] vhost: support upto 509 memory regions
Message-ID: <20150617151030-mutt-send-email-mst@redhat.com>
References: <20150617083202-mutt-send-email-mst@redhat.com>
 <20150617092802.5c8d8475@igors-macbook-pro.local>
 <20150617092910-mutt-send-email-mst@redhat.com>
 <20150617105421.71751f44@nial.brq.redhat.com>
 <20150617110711-mutt-send-email-mst@redhat.com>
 <20150617123742.5c3fec30@nial.brq.redhat.com>
 <20150617123842-mutt-send-email-mst@redhat.com>
 <20150617134803.5a03d04e@nial.brq.redhat.com>
 <20150617134848-mutt-send-email-mst@redhat.com>
 <20150617142339.6e6deb12@nial.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150617142339.6e6deb12@nial.brq.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1548
Lines: 35

On Wed, Jun 17, 2015 at 02:23:39PM +0200, Igor Mammedov wrote:
> On Wed, 17 Jun 2015 13:51:56 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Wed, Jun 17, 2015 at 01:48:03PM +0200, Igor Mammedov wrote:
> > > > > So far it's kernel limitation and this patch fixes crashes
> > > > > that users see now, with the rest of patches enabling performance
> > > > > not to regress.
> > > > 
> > > > When I say regression I refer to an option to limit the array
> > > > size again after userspace started using the larger size.
> > > Is there a need to do so?
> > 
> > Considering userspace can be malicious, I guess yes.
> I don't think it's a valid concern in this case,
> setting limit back from 509 to 64 will not help here in any way,
> userspace still can create as many vhost instances as it needs
> to consume memory it desires.

Not really since vhost char device isn't world-accessible.
It's typically opened by a priveledged tool, the fd is
then passed to an unpriveledged userspace, or permissions dropped.

> > 
> > > Userspace that cares about memory footprint won't use many slots
> > > keeping it low and user space that can't do without many slots
> > > or doesn't care will have bigger memory footprint.
> > 
> > We really can't trust userspace to do the right thing though.
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/