From: Sifan Naeem <Sifan.Naeem@imgtec.com>
To: Jonas Gorski <jogo@openwrt.org>
CC: Mark Brown <broonie@kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Bresticker <abrestic@chromium.org>
Subject: RE: [PATCH v2] spi: img-spfi: Same Edge bit set to double supported
 transfer speed
Thread-Topic: [PATCH v2] spi: img-spfi: Same Edge bit set to double
 supported transfer speed
Thread-Index: AQHQqORGm9gH8JpqV0iTo8UOMexf1p2wiyWAgAAebpA=
Date: Wed, 17 Jun 2015 13:36:03 +0000
Message-ID: <A0E307549471DA4DBAF2DE2DE6CBFB7E4961964D@hhmail02.hh.imgtec.org>
References: <1434535262-7393-1-git-send-email-sifan.naeem@imgtec.com>
 <CAOiHx=ntO2tp7SjU7-f=1oxDa3FJZ6z4gxeu7ZBsUsaijpAK0g@mail.gmail.com>
In-Reply-To: <CAOiHx=ntO2tp7SjU7-f=1oxDa3FJZ6z4gxeu7ZBsUsaijpAK0g@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2798
Lines: 64

Hi Jonas,

> -----Original Message-----
> From: Jonas Gorski [mailto:jogo@openwrt.org]
> Sent: 17 June 2015 13:12
> To: Sifan Naeem
> Cc: Mark Brown; linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org;
> Andrew Bresticker
> Subject: Re: [PATCH v2] spi: img-spfi: Same Edge bit set to double supported
> transfer speed
> 
> Hi,
> 
> On Wed, Jun 17, 2015 at 12:01 PM, Sifan Naeem <sifan.naeem@imgtec.com>
> wrote:
> > Same edge bit set in SPFI Control register to double the supported
> > spfi clock speed. Setting this bit increases the supported spfi
> > frequency from 1/8 to 1/4 of the core clock frequency.
> >
> > Without this bit set the maximum speed supported was 25MHz on
> > Pistachio.
> >
> > Change-Id: I26782ea88ac3567e72dac11e46c5b5f5f52c5e3d
> > Signed-off-by: Sifan Naeem <sifan.naeem@imgtec.com>
> > ---
> >  drivers/spi/spi-img-spfi.c |    2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c
> > index 788e2b1..acce90a 100644
> > --- a/drivers/spi/spi-img-spfi.c
> > +++ b/drivers/spi/spi-img-spfi.c
> > @@ -40,6 +40,7 @@
> >  #define SPFI_CONTROL_SOFT_RESET                        BIT(11)
> >  #define SPFI_CONTROL_SEND_DMA                  BIT(10)
> >  #define SPFI_CONTROL_GET_DMA                   BIT(9)
> > +#define SPFI_CONTROL_SE                        BIT(8)
> >  #define SPFI_CONTROL_TMODE_SHIFT               5
> >  #define SPFI_CONTROL_TMODE_MASK                        0x7
> >  #define SPFI_CONTROL_TMODE_SINGLE              0
> > @@ -491,6 +492,7 @@ static void img_spfi_config(struct spi_master
> *master, struct spi_device *spi,
> >         else if (xfer->tx_nbits == SPI_NBITS_QUAD &&
> >                  xfer->rx_nbits == SPI_NBITS_QUAD)
> >                 val |= SPFI_CONTROL_TMODE_QUAD <<
> > SPFI_CONTROL_TMODE_SHIFT;
> > +       val |= SPFI_CONTROL_SE;
> >         spfi_writel(spfi, val, SPFI_CONTROL);  }
> 
> Don't you also need to update master->max_speed_hz? And if it doubles the
> clock speed, don't you need to reflect that in the calculation for the devider?
> Currently it looks like it would just cause all transfers to go with the doubled
> requested rate. But maybe I'm missing something.
> 
max_speed_hz is already set to 1/4  of the Core clock. So I don't think we need to change that.
In Pistachio SoC the max speed of SPFI block is limited to 1/4 of the core clock or to 50Mhz, to achieve these values the change suggested in this patch should have always been set. In the device tree node for SPFI we have to mention the limit of 50Mhz as spi-max-frequency = <50000000>;

Thanks,
Sifan

> 
> Regards
> Jonas
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?