Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756646AbbFQOTA (ORCPT ); Wed, 17 Jun 2015 10:19:00 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:56291 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443AbbFQOSv (ORCPT ); Wed, 17 Jun 2015 10:18:51 -0400 Message-ID: <558181C2.6020500@hitachi.com> Date: Wed, 17 Jun 2015 23:18:42 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Long , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Russell King CC: "Jon Medhurst (Tixy)" , Steve Capper , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, Anil S Keshavamurthy , Mark Brown , sandeepa.s.prabhu@gmail.com, William Cohen , davem@davemloft.net Subject: Re: [PATCH v7 0/7] arm64: Add kernel probes (kprobes) support References: <1434395229-6654-1-git-send-email-dave.long@linaro.org> In-Reply-To: <1434395229-6654-1-git-send-email-dave.long@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4112 Lines: 100 Hi David, At first, thank you for updating this series! :) On 2015/06/16 4:07, David Long wrote: > From: "David A. Long" > > This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches, > first seen in October 2013. This version attempts to address concerns raised by > reviewers and also fixes problems discovered during testing. > > This patchset adds support for kernel probes(kprobes), jump probes(jprobes) > and return probes(kretprobes) support for ARM64. > > The kprobes mechanism makes use of software breakpoint and single stepping > support available in the ARM v8 kernel. > > The is patch depends on: > [PATCH 1/2] Move the pt_regs_offset struct definition from arch to common include file > [PATCH 2/2] Consolidate redundant register/stack access code > Hmm, what are those patches ? Would they be not merged to upstream yet? If so, where I can get them from? I'd like to know the actual url for them. [...] > Changes since v6 include: > > 1) New trampoline code from Will Cohen fixes the occasional failure seen > when processing kretprobes by replacing the software breakpoint with > assembly code to implement the return to the original execution stream. Yeah, that's what we need :) Thank you, > 2) Changed ip0, ip1, fp, and lr to plain numbered registers for purposes > of recognizing them as an ascii string in the stack/reg access code. > 3) Removed orig_x0. > 4) Moved ARM_x* defines from arch/arm64/include/uapi/asm/ptrace.h to > arch/arm64/kernel/ptrace.c. > > David A. Long (2): > arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature > arm64: Add more test functions to insn.c > > Sandeepa Prabhu (4): > arm64: Kprobes with single stepping support > arm64: kprobes instruction simulation support > arm64: Add kernel return probes support (kretprobes) > kprobes: Add arm64 case in kprobe example module > > William Cohen (1): > arm64: Add trampoline code for kretprobes > > arch/arm64/Kconfig | 3 + > arch/arm64/include/asm/debug-monitors.h | 5 + > arch/arm64/include/asm/insn.h | 18 + > arch/arm64/include/asm/kprobes.h | 63 +++ > arch/arm64/include/asm/probes.h | 50 +++ > arch/arm64/include/asm/ptrace.h | 28 +- > arch/arm64/kernel/Makefile | 3 + > arch/arm64/kernel/debug-monitors.c | 35 +- > arch/arm64/kernel/insn.c | 28 ++ > arch/arm64/kernel/kprobes-arm64.c | 166 ++++++++ > arch/arm64/kernel/kprobes-arm64.h | 71 ++++ > arch/arm64/kernel/kprobes.c | 665 +++++++++++++++++++++++++++++++ > arch/arm64/kernel/kprobes.h | 24 ++ > arch/arm64/kernel/probes-condn-check.c | 122 ++++++ > arch/arm64/kernel/probes-simulate-insn.c | 174 ++++++++ > arch/arm64/kernel/probes-simulate-insn.h | 33 ++ > arch/arm64/kernel/ptrace.c | 77 ++++ > arch/arm64/kernel/vmlinux.lds.S | 1 + > arch/arm64/mm/fault.c | 25 ++ > samples/kprobes/kprobe_example.c | 8 + > 20 files changed, 1588 insertions(+), 11 deletions(-) > create mode 100644 arch/arm64/include/asm/kprobes.h > create mode 100644 arch/arm64/include/asm/probes.h > create mode 100644 arch/arm64/kernel/kprobes-arm64.c > create mode 100644 arch/arm64/kernel/kprobes-arm64.h > create mode 100644 arch/arm64/kernel/kprobes.c > create mode 100644 arch/arm64/kernel/kprobes.h > create mode 100644 arch/arm64/kernel/probes-condn-check.c > create mode 100644 arch/arm64/kernel/probes-simulate-insn.c > create mode 100644 arch/arm64/kernel/probes-simulate-insn.h > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/