Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932338AbbFQR6G (ORCPT ); Wed, 17 Jun 2015 13:58:06 -0400 Received: from mail-bn1bon0146.outbound.protection.outlook.com ([157.56.111.146]:28350 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755544AbbFQR6C (ORCPT ); Wed, 17 Jun 2015 13:58:02 -0400 Authentication-Results: freescale.com; dkim=none (message not signed) header.d=none; Message-ID: <1434563871.2353.90.camel@freescale.com> Subject: Re: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers From: Scott Wood To: Liberman Igal-B31950 CC: Bucur Madalin-Cristian-B32716 , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Date: Wed, 17 Jun 2015 12:57:51 -0500 In-Reply-To: References: <1433949712-5648-1-git-send-email-madalin.bucur@freescale.com> <1433949712-5648-2-git-send-email-madalin.bucur@freescale.com> <1433949712-5648-3-git-send-email-madalin.bucur@freescale.com> <1433962446.2477.121.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: CY1PR0601CA0015.namprd06.prod.outlook.com (25.160.162.25) To BY1PR03MB1481.namprd03.prod.outlook.com (25.162.210.14) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;2:b0XIxKVcj/N0v8URnFZQ1KkHp5za+Ax6Ud1G9q/+r4rjNDbyLaboOVzXGf6QSiYW;2:3Yw9BGCoOlrd1T4NRTXZHtxknOOSXshoVbgaFtO8k5qUWSbGj0aDW6fQEc6HEKaV880cYorZjtzvcHvXwGRg5opm/hexh1BfNaNcMZ82HxZMUGi7Fts2qvCBzfehh1it01FETwHol7mgZvKFPGrVog==;6:1mv41uNebcXcRB6bcVjyjdL+/YUnfK0eT0GHos22D9vTGdRjw0gF3WQHxs6Kev2OYn3t3GoPQ5uPtwpJXa+0gB9GBOzRQgIoiQR5xcR5O7jCVBcl1BWl+VWP0TxRzpw/i3dC+9IuvCFPFBBzB30TxJXExncoV7MZHPwqhnSNDtky3Iw+tdDbIwCCrAeg5dAUhgAyWDyBJRHDMnvg9lcI0R5/pQ7H6GZr9LlIA0RoNRDbsTZqxjbkUdfbEwiaEpFL27sZiG+i5WOB4W/0dXlEyNgcgHyV8lR0WcTdkAWnQtdbA/3iqSQZzVJgeZFJRr+nMxvHFyfQIvjA16kpIt7WbP4cnYAclXiD3q827Kp+M7/NOGt7xAg8tdCvEN9gFA+xTBA6V9RtzJRE97F8e9+vU/0W/moE7sdRLyIXdipvzXs7JLkN5tmSl+1Bo49yjcHwiS3saJvO2kICyc62RfAb8RaHJ62hnHJ865l9PScLpNTE7rcc7AKFN/KYkmCn4MWd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1481;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1513; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY1PR03MB1481;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1481; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;3:F2bNu+i5m+TKYgGqW0+O3wAZGI46EUBXkir1Wue+EPIEZIsP0R4r51ZVS5Sibp7PkYMoLkZS349D6YO66noVHorVQ8cQ21PQumYEZ1XUbenDGhWkn9QmSNCJZOhdzrZ21U1BelsVNUZnr01wv5G0X3wHP8To2cfm/tJoXRJO0Qf8rXU86nzZWyQCNKy2L7WGheoLa3CqBPDFlBWRj2G2BUxuDtHfc37mtvSj4RztJI347W0Kr7ahr8hgaq0N2x/hAv35hEad7efWLTBIlKNtgmalsJ6T4dhogRqd6+wLgmEfvIRrJpVMunikIvhc/svz X-Forefront-PRVS: 0610D16BBE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(24454002)(13464003)(51704005)(377424004)(50986999)(76176999)(47776003)(122386002)(50466002)(189998001)(23676002)(5820100001)(62966003)(77156002)(46102003)(19580395003)(19580405001)(40100003)(2950100001)(50226001)(92566002)(103116003)(33646002)(86362001)(42186005)(36756003)(5001960100002)(110136002)(77096005)(93886004)(87976001)(4001450100001)(19627235001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1481;H:[IPv6:2601:448:8100:f9f:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;9:32KwqxSyla58d3IaRSCawdJJxzY0WvicaWacYxHdHcXNPN2cdO2sNry+93Wdjih4SEcjdxsyD/TbNv50iWK+WGmt6X/VWSBRCBzIAorbbL/G4O+KQMwdbAqZY2MnFczPUTOIZgp9AmqksxJeVVhqE9mTebjO2AV4eBVhx17E78vSxqs3mEUhqUa34Yc0j4ygQ1qNMfXFWOxVPEWRixlWGkDw+FRKy8GWeKk1ZMa/uxidhFam4d5vPcFoQx+IBpRPMs9PSyCXkHjoLRqZ2GD44hL/m/rC75vI48pqoBf1i9koGfP+tj+K42PdrekJyQVeuwtP7Gml+8MR0rv3u5R1e1tcQj92mbGOEbWgnKxfDeoNNmQKNbOz6My2jySNODfrkiGTkdEd4d8+uayhOs2OiQXvYcUbDZE8XV40HtdBHr1c754dfa9tTs8VEKbZLz9iH0rolJpl+u5Uws/1OX9a58AF1FCtR2P/60qKSgBQy3xXR7inso9qJokXJfTuYOzhY89rSyQ+bEQ5axXM20GxuOAzUu1DFwTgpbYTi7SJSNu9T9WDEO0OeIX377QcQ1SSfECUUtlWHEYHZp9/XHXC2kJjdy4ghclIKKN5dSRd3RtdALtabGSnpWa2pbJGPYswScDhJ5rSq5XTWBs9KOVKwYnGEyuvktO64zNgwVJmhWaWHoXqYiF7CrDiZZBf3hQLxQHHfH86Rlyba/441iM8c+SPVbMdQHvPnJkASjChmiGmfexgLI6N+7H8JQ4pZ+FSOfo615IAEHxIE2JUCEP5SwR124no6WVSFFZXoh/iJQgh+tJ9HUTfrAW+/7gtPjI87aLNpXe9cNnq2k1BCSiEbZaEeghLTYSaMLGYM7l6QQUSgBWLUBV5UuxYDgFdBEhHVMoQIclfWXkduTOggaghE7JTDQn/W6GW67zcqt9xJEqiNhNLjNYAX7kQuNk14iHU X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;3:lV9y49lnFEGCR+vuPNn35vdPsybIriYgL3MEhOMDfxi4rJCbJunlS8W2wfvbfU2/kmr/fwVab/OhdXmgTiG2BA4t4zceRr650j5AB714XKlA/1X2537laiCroeaxDobxfTlDtgCIo4Sc3kaweQDQFQ==;10:zzlMn8U47vGlNCScIslx8u/hNdkvksE817FgkJ6v2JR2dwCmsPrfln/lrtHnIDTJw19spHnfLRAUX92z2vjZjZYiHy5HpHjxslaJsQRO2ms=;6:A5byaB2wcBARW+wDmo2EehVamRyRHT7JoovI0ySx/fLGf+vIUG23Bu5gkuhGHFlc X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2015 17:57:58.1252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1481 X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1513;2:RTxrpZXnHLdbyQVn2mpNzCOwouR2UQY3amwFOQnFIVZ8+GJhRHpg5k3kDTuhA3P5;2:LZvU0XECCkcat7qDq2uhslja3cAFnTFXoZcQ4/Yw6Dng/8T8TQBE6LvpqAoIZ03YVn7M4plQODITCmqhJb8eMLVwcL7BJidnB+hJv7odwyjEKkLucEIai80NAi2aV6fuTNfZ5tT349GlNLtWNVX8rQ==;9:iv0N0+lPwohIyksSDhMCBAgWoUZ5NYGioowDAODc7pOBQFz3uDX8XLkKgd6A7hDEpMrMkhxVZeBZf9YonJhCANHQTKy/BPRPjOXVia2ZBqafGsYT0c/s2xAQLVps/1F34rQYyjfqTWQJsATZ6LtdEw== X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2932 Lines: 88 On Wed, 2015-06-17 at 09:59 -0500, Liberman Igal-B31950 wrote: > > Regards, > Igal Liberman. > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, June 10, 2015 9:54 PM > > To: Bucur Madalin-Cristian-B32716 > > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linuxppc- > > dev@lists.ozlabs.org; Liberman Igal-B31950 > > Subject: Re: [PATCH 01/12] fsl/fman: Add the FMan FLIB headers > > > > On Wed, 2015-06-10 at 18:21 +0300, Madalin Bucur wrote: > > > From: Igal Liberman > > > > > > This patch presents the FMan Foundation Libraries (FLIB) headers. > > > The FMan FLib provides the basic API used by the FMan drivers to > > > configure and control the FMan hardware. > > > > > > Signed-off-by: Igal Liberman > > > --- > > > .../ethernet/freescale/fman/flib/common/general.h | 41 ++ > > > .../net/ethernet/freescale/fman/flib/fsl_fman.h | 609 > > > +++++++++++++++++++++ > > > 2 files changed, 650 insertions(+) > > > create mode 100644 > > > drivers/net/ethernet/freescale/fman/flib/common/general.h > > > create mode 100644 > > > drivers/net/ethernet/freescale/fman/flib/fsl_fman.h > > > > Why do we need separate patches just for headers? > > > > We wanted to make the patches smaller, it's the main reason for this > separation. Patches should be divided by function, not arbitrarily in order to decrease size. Splitting like this makes it harder to see the whole picture, to search for identifiers, etc. The right way to make these patches smaller is to remove unnecessary features. > > What does the flib directory mean, in the context of Linux? If > > someone were > > to add code to this driver, how do they know if the code should go > > into the > > flib directory or not? > > > > > > > > +#define iowrite32be(val, addr) out_be32(&(*addr), > > > val) > > > +#define ioread32be(addr) in_be32(&(*addr)) > > > > iowrite32be()/ioread32be() are already defined for all relevant > > architectures. > > Why are you redefining them into something PPC- specific? > > > > Removed those. Please don't stop at the specific things I'm pointing out. > > > +/* do not change! if changed, must be disabled for rev1 ! */ > > > #define > > > +DEFAULT_HALT_ON_EXTERNAL_ACTIVATION false > > > +/* do not change! if changed, must be disabled for rev1 ! */ > > > #define > > > +DEFAULT_HALT_ON_UNRECOVERABLE_ECC_ERROR false > > > > rev1 of what chip? > > > > P4080. I'll update the comments. No. p4080rev1 is not supported, and in any case this is not the right way to select different errata for different chips. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/