Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756251AbbFQTY1 (ORCPT ); Wed, 17 Jun 2015 15:24:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591AbbFQTYT (ORCPT ); Wed, 17 Jun 2015 15:24:19 -0400 Date: Wed, 17 Jun 2015 16:24:04 -0300 From: Arnaldo Carvalho de Melo To: Stephane Eranian Cc: LKML , Jiri Olsa , Namhyung Kim , David Ahern , Peter Zijlstra , "mingo@elte.hu" Subject: Re: [BUG] perf report: fails to symbolize when vaddr is non zero for shared objects Message-ID: <20150617192404.GD2368@redhat.com> References: <20150616143401.GA2548@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 32 Em Wed, Jun 17, 2015 at 11:54:12AM -0700, Stephane Eranian escreveu: > On Tue, Jun 16, 2015 at 7:34 AM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jun 16, 2015 at 12:03:01AM -0700, Stephane Eranian escreveu: > >> If you get samples in the shared lib, they will be off, possibly > >> attributed to the wrong > >> functions. > >> > >> Could this be fixed quickly? > > > > You tell me, do you have a patch to propose? :-) > Well, need to make sure I understand the code flow in dso__load_sym() > and callers. > You have elf_read_maps() which seems to be reading the phdr but, it > would need to be called systematically for ET_DYN. I will experiment > with this. > Worst case, we need to add another function to read the phdr and use > the p_vaddr. Ok, that symbols* code grew unwieldly complex, need to give it some love and refactoring care at some point... Thanks! - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/