Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757333AbbFQTfr (ORCPT ); Wed, 17 Jun 2015 15:35:47 -0400 Received: from mail.kernel.org ([198.145.29.136]:34204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbbFQTfj (ORCPT ); Wed, 17 Jun 2015 15:35:39 -0400 Date: Wed, 17 Jun 2015 16:35:33 -0300 From: Arnaldo Carvalho de Melo To: "Wangnan (F)" Cc: Hou Pengyang , namhyung@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf unwind: Fix a compile error Message-ID: <20150617193533.GD3079@kernel.org> References: <1434453395-10560-1-git-send-email-houpengyang@huawei.com> <20150616134750.GC10374@kernel.org> <55815F49.5040703@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55815F49.5040703@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1951 Lines: 56 Em Wed, Jun 17, 2015 at 07:51:37PM +0800, Wangnan (F) escreveu: > > > On 2015/6/16 21:47, Arnaldo Carvalho de Melo wrote: > >Em Tue, Jun 16, 2015 at 11:16:35AM +0000, Hou Pengyang escreveu: > >>When libunwind is on, there is a compile error as : > >> > >>util/unwind-libunwind.c:363:21: error: 'dso' undeclared (first use in this function) > >> dso__data_put_fd(dso); > >> > >>This patch fix it. > >Thanks, applied. > > > >- Arnaldo > > I just realized that I posted this patch several weeks ago and has been > acked. Please see: > > http://lkml.kernel.org/r/CAM9d7cjkjcF_7AeZ0d7kyDLWwjutLpJm-MfdDR42tr=iQYnz6g@mail.gmail.com > > I'll reply that post to note others about this one. > > Anyway, thank you for fixing this problem. Sorry, some patches sometimes gets lost, I should've applied yours, sooner, but what matters is that the problem got solved. Thanks, - Arnaldo > >>Fixes: 4bb11d012ab248d0 ("perf tools: Add dso__data_get/put_fd()") > >>Signed-off-by: Hou Pengyang > >>--- > >> tools/perf/util/unwind-libunwind.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c > >>index f079b63..4c00507 100644 > >>--- a/tools/perf/util/unwind-libunwind.c > >>+++ b/tools/perf/util/unwind-libunwind.c > >>@@ -360,7 +360,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi, > >> unw_word_t base = is_exec ? 0 : map->start; > >> if (fd >= 0) > >>- dso__data_put_fd(dso); > >>+ dso__data_put_fd(map->dso); > >> memset(&di, 0, sizeof(di)); > >> if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name, > >>-- > >>1.8.5.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/