Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754833AbbFQVTQ (ORCPT ); Wed, 17 Jun 2015 17:19:16 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:60547 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343AbbFQVTI (ORCPT ); Wed, 17 Jun 2015 17:19:08 -0400 X-Helo: d28dlp01.in.ibm.com X-MailFrom: honclo@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] vTPM: support little endian guests From: "Hon Ching (Vicky) Lo" To: Ashley Lai Cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten In-Reply-To: References: <1433901293-29352-1-git-send-email-honclo@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 17 Jun 2015 17:18:56 -0400 Message-ID: <1434575936.5335.2.camel@vtpm2014.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15061721-0021-0000-0000-000005D24775 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 41 Hi Ashley, Ah, good catch. I think I can only join the first two lines (where the assignments are) and will have to leave the rest splitted. I'll resubmit this one soon. Thanks for the review! Vicky On Tue, 2015-06-16 at 20:17 -0500, Ashley Lai wrote: > Just a small comment otherwise it looks good. > > On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: > > case NONHOST_INFO: > > - name = tcpa_event_type_strings[event->event_type]; > > + name = > > + tcpa_event_type_strings[do_endian_conversion > > + (event->event_type)]; > Not being picky but if it does not exceed 80 characters it looks better > to join the line above. > name = tcpa_event_type_strings[do_endian_conversion > (event->event_type)]; > > > case POST_CONTENTS: > > - name = tcpa_pc_event_id_strings[pc_event->event_id]; > > + name = > > + tcpa_pc_event_id_strings[do_endian_conversion > > + (pc_event->event_id)]; > Same as above. > > Thanks, > --Ashley Lai > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/