Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756370AbbFQXVI (ORCPT ); Wed, 17 Jun 2015 19:21:08 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:36754 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbbFQXVE (ORCPT ); Wed, 17 Jun 2015 19:21:04 -0400 Date: Wed, 17 Jun 2015 16:21:02 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Sergey Senozhatsky cc: Andrew Morton , Minchan Kim , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sergey.senozhatsky.work@gmail.com Subject: Re: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy() In-Reply-To: <1433851493-23685-3-git-send-email-sergey.senozhatsky@gmail.com> Message-ID: References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> <1433851493-23685-3-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 30 On Tue, 9 Jun 2015, Sergey Senozhatsky wrote: > mempool_destroy() does not tolerate a NULL mempool_t pointer > argument and performs a NULL-pointer dereference. This requires > additional attention and effort from developers/reviewers and > forces all mempool_destroy() callers to do a NULL check > > if (pool) > mempool_destroy(pool); > > Or, otherwise, be invalid mempool_destroy() users. > > Tweak mempool_destroy() and NULL-check the pointer there. > > Proposed by Andrew Morton. > > Signed-off-by: Sergey Senozhatsky > Reported-by: Andrew Morton > LKML-reference: https://lkml.org/lkml/2015/6/8/583 Acked-by: David Rientjes I like how your patch series is enabling us to remove many lines from the source code. But doing s/Reported-by/Suggested-by/ can also make your changelog two lines shorter ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/