Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751037AbbFQX4t (ORCPT ); Wed, 17 Jun 2015 19:56:49 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:11071 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750772AbbFQX4s (ORCPT ); Wed, 17 Jun 2015 19:56:48 -0400 Message-ID: <5582090E.5060209@fb.com> Date: Wed, 17 Jun 2015 16:55:58 -0700 From: Yannick Brosseau User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Jeff Epler CC: , , , , , , , Subject: Re: [PATCH] perf report: Fix sort__sym_cmp to also compare end of symbol References: <1434584470-17771-1-git-send-email-scientist@fb.com> <20150617235343.GB84349@unpythonic.net> In-Reply-To: <20150617235343.GB84349@unpythonic.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-06-17_08:2015-06-16,2015-06-17,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 18 On 06/17/2015 04:53 PM, Jeff Epler wrote: > On Wed, Jun 17, 2015 at 04:41:10PM -0700, Yannick Brosseau wrote: >> When using a map file from a JIT, due to memory reuse, we can >> obtain multiple symbols with the same start address but a different >> length. > Is there some reason it's impossible for the reused memory to have the > same length / end address? > It's possible that they are the same, and in that case the function returns 0. The patch is adding the handling of the case where they are different. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/